[FLINK-40143][core] Fix displayed restart strategy for config option based restart strategies#28736
Open
csurong wants to merge 1 commit into
Open
[FLINK-40143][core] Fix displayed restart strategy for config option based restart strategies#28736csurong wants to merge 1 commit into
csurong wants to merge 1 commit into
Conversation
Collaborator
96b481a to
a5f236a
Compare
…based restart strategies Generated-by: OpenAI Codex (GPT-5)
a5f236a to
53a5d5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes FLINK-40143 on the
release-1.20branch.Jobs configured through the
restart-strategy.*options use the correct job-level restart strategy at runtime, but the archived execution configuration exposed by/jobs/:jobid/configand the Dashboard can displayCluster level default restart strategy.Current master is not affected because FLINK-36249 changed
ArchivedExecutionConfigto derive this description from the configuration. This PR is a targeted compatibility fix for release-1.20 that also preserves the behavior of the deprecated explicit restart strategy APIs.Brief change log
ExecutionConfig.toConfiguration()when the deprecated restart strategy object is the fallback strategy.Verifying this change
This change added tests and can be verified as follows:
mvn -q -Denforcer.skip -pl flink-core -Dtest=ExecutionConfigTest testmvn -q -Denforcer.skip -pl flink-runtime -Dtest=JobConfigHandlerTest,RestartBackoffTimeStrategyFactoryLoaderTest testBoth commands pass on the latest
release-1.20branch.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex (GPT-5)