[FLINK-40135][python] Prevent Beam state access after runner shutdown#28716
Open
bowenli86 wants to merge 1 commit into
Open
[FLINK-40135][python] Prevent Beam state access after runner shutdown#28716bowenli86 wants to merge 1 commit into
bowenli86 wants to merge 1 commit into
Conversation
Collaborator
Generated-by: Codex GPT-5
1911cee to
ab4b2c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This change prevents Beam state requests from accessing Flink state after Python runner shutdown has completed. During task cancellation, Beam state callbacks can otherwise overlap keyed state backend disposal and access closed RocksDB native resources.
Brief change log
BeamStateRequestHandler.Verifying this change
This change added tests and can be verified as follows:
./mvnw -q -pl flink-python -am -Dflink.markBundledAsOptional=false -Dtest=BeamStateRequestHandlerTest,BeamPythonFunctionRunnerTest -Dsurefire.failIfNoSpecifiedTests=false -Dfast -Pskip-webui-build -T1 test./mvnw -f flink-python/pom.xml spotless:check./mvnw -f flink-python/pom.xml checkstyle:checkDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Codex GPT-5