-
Notifications
You must be signed in to change notification settings - Fork 2.2k
FINERACT 263 : "Add Notes" for Centers permission is missing #5346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
FINERACT 263 : "Add Notes" for Centers permission is missing #5346
Conversation
|
Hi reviewers, |
b9d85d4 to
de93454
Compare
adamsaghy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR content has nothing to do with PR title...
Really sorry all changes did not got commited. I'll update it shortly. |
|
@Monica-CodingWorld squash and commit your changes, make sure that only 1 commit is in the PR. Also you have to test it in your local dev env. |
458f0f4 to
f737698
Compare
- Add CENTER enum value to NoteType - Add centerId field and withCenterId() method to CommandWrapperBuilder - Add CENTER case in NotesApiResource.getResourceDetails() - Enable separate permissions for Read, Create, Update, Delete center notes - Follows same permission pattern as existing GROUP notes
f737698 to
02188d7
Compare
@IOhacker Thank you for the guidance, i made all the changes. Best Regards, |
|
@Monica-CodingWorld could you please check the output https://github.com/apache/fineract/actions/runs/21178884898/job/61230181309?pr=5346 |
@IOhacker Thanks for the review. I've looked into the CI build failure. The error occurs because the addition of the centerId parameter to the CommandWrapper constructors requires updates in a few more places that instantiate the class. I have now identified and fixed these remaining instances (added null for the centerId parameter where appropriate) and have pushed the corrections. The build should pass now. |
|
:) always remember to squash and commit. Please help us with that. |
616d1d0 to
02188d7
Compare
Description
This PR fixes missing permission handling for Center Notes in the Notes API.
Previously, when accessing notes for a CENTER resource, the request fell into the default case, resulting in a NoteResourceNotSupportedException. This allowed center notes to be accessed without proper, explicit permission mapping.
changes made:
Jira issue:- https://issues.apache.org/jira/projects/FINERACT/issues/FINERACT-263
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.