Skip to content

fix(dataZoom): keep toolbox zoom from dropping stacked areas #21600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
susiwen8 wants to merge 3 commits into
base: master
Choose a base branch
from
+262 −2
Open

fix(dataZoom): keep toolbox zoom from dropping stacked areas #21600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c48251
Keep toolbox dataZoom from dropping stacked areas
susiwen8 May 2, 2026
53edc47
Cover toolbox dataZoom filter modes for stacked data
susiwen8 May 2, 2026
7d0292f
Assert empty dataZoom preserves in-window raw stack values
susiwen8 May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/component/dataZoom/AxisProxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import { Dictionary } from '../../util/types';
// TODO Polar?
import DataZoomModel from './DataZoomModel';
import { AxisBaseModel } from '../../coord/AxisBaseModel';
import { unionAxisExtentFromData } from '../../coord/axisHelper';
import { getDataDimensionsOnAxis, unionAxisExtentFromData } from '../../coord/axisHelper';
import { ensureScaleRawExtentInfo } from '../../coord/scaleRawExtentInfo';
import { getAxisMainType, isCoordSupported, DataZoomAxisDimension } from './helper';
import { SINGLE_REFERRING } from '../../util/model';
Expand Down Expand Up @@ -297,7 +297,9 @@ class AxisProxy {

each(seriesModels, function (seriesModel) {
let seriesData = seriesModel.getData();
const dataDims = seriesData.mapDimensionsAll(axisDim);
// Use the same dimensions as axis extent calculation. Stacked series
// are rendered by their stack result dimension, not the original value dimension.
const dataDims = getDataDimensionsOnAxis(seriesData, axisDim);
Comment thread
susiwen8 marked this conversation as resolved.
Comment thread
susiwen8 marked this conversation as resolved.

if (!dataDims.length) {
return;
Expand Down
137 changes: 137 additions & 0 deletions test/toolbox-dataZoom-stack-area.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

121 changes: 121 additions & 0 deletions test/ut/spec/component/dataZoom/AxisProxy.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.