Skip to content

Conversation

@kaka11chen
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

[opt] (hive-writer) Change the default value of hive staging dir.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaka11chen
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32811 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2452c3fa8f50a3522296326328f5141d2af0f382, data reload: false

------ Round 1 ----------------------------------
q1	17632	5299	5057	5057
q2	2096	333	188	188
q3	10140	1406	725	725
q4	10189	812	311	311
q5	7529	2250	1909	1909
q6	194	181	150	150
q7	868	718	600	600
q8	9277	1368	1157	1157
q9	5130	4818	4838	4818
q10	6773	1937	1554	1554
q11	512	290	283	283
q12	329	375	218	218
q13	17756	4019	3208	3208
q14	237	241	212	212
q15	868	826	809	809
q16	654	687	615	615
q17	618	773	510	510
q18	6788	6537	7642	6537
q19	1294	1048	661	661
q20	419	359	242	242
q21	2909	2291	1990	1990
q22	1133	1088	1057	1057
Total cold run time: 103345 ms
Total hot run time: 32811 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5718	5564	5531	5531
q2	278	361	253	253
q3	2311	3051	2438	2438
q4	1466	1887	1504	1504
q5	4716	4540	4455	4455
q6	231	179	137	137
q7	2054	1886	1753	1753
q8	2535	2474	2355	2355
q9	7493	7357	7574	7357
q10	2846	3062	2599	2599
q11	546	513	455	455
q12	710	803	631	631
q13	3894	4326	3573	3573
q14	290	291	258	258
q15	841	792	791	791
q16	628	683	686	683
q17	1078	1231	1276	1231
q18	7568	7266	7315	7266
q19	816	809	794	794
q20	1961	2059	1869	1869
q21	4392	4200	4062	4062
q22	1050	1038	967	967
Total cold run time: 53422 ms
Total hot run time: 50962 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.24 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2452c3fa8f50a3522296326328f5141d2af0f382, data reload: false

query1	0.05	0.05	0.05
query2	0.11	0.05	0.05
query3	0.26	0.09	0.08
query4	1.61	0.11	0.11
query5	0.27	0.24	0.24
query6	1.17	0.66	0.66
query7	0.03	0.02	0.02
query8	0.05	0.03	0.04
query9	0.56	0.51	0.49
query10	0.56	0.52	0.55
query11	0.14	0.10	0.09
query12	0.13	0.10	0.11
query13	0.64	0.61	0.61
query14	1.07	1.04	1.05
query15	0.90	0.87	0.87
query16	0.37	0.40	0.39
query17	1.14	1.18	1.11
query18	0.22	0.21	0.21
query19	2.09	2.00	2.03
query20	0.02	0.01	0.02
query21	15.40	0.28	0.14
query22	5.04	0.04	0.04
query23	15.88	0.28	0.10
query24	1.19	0.56	0.32
query25	0.08	0.05	0.06
query26	0.14	0.14	0.13
query27	0.05	0.06	0.05
query28	3.32	1.16	0.96
query29	12.55	3.87	3.11
query30	0.27	0.12	0.11
query31	2.81	0.61	0.41
query32	3.24	0.59	0.49
query33	3.22	3.23	3.26
query34	16.02	5.37	4.71
query35	4.85	4.83	4.85
query36	0.66	0.50	0.50
query37	0.11	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.18	0.16
query41	0.10	0.03	0.03
query42	0.04	0.03	0.02
query43	0.05	0.04	0.03
Total cold run time: 96.7 s
Total hot run time: 28.24 s

@kaka11chen
Copy link
Contributor Author

run external

1 similar comment
@kaka11chen
Copy link
Contributor Author

run external

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@kaka11chen kaka11chen force-pushed the change_hive_staging_dir_def_value_master branch from 2452c3f to f0da81d Compare January 28, 2026 00:46
@kaka11chen
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32583 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f0da81dd5ae12bca98dbfbfab3a8f528bcaa0167, data reload: false

------ Round 1 ----------------------------------
q1	17883	5236	5027	5027
q2	2173	309	216	216
q3	10230	1316	776	776
q4	10241	776	309	309
q5	7512	2190	1921	1921
q6	201	184	152	152
q7	870	774	623	623
q8	9290	1354	1159	1159
q9	5184	4899	4847	4847
q10	7017	1970	1568	1568
q11	582	298	279	279
q12	402	375	223	223
q13	17802	4101	3242	3242
q14	232	245	217	217
q15	907	815	820	815
q16	696	677	614	614
q17	640	780	518	518
q18	6742	6543	6372	6372
q19	1346	1006	628	628
q20	399	346	239	239
q21	2738	2149	1885	1885
q22	1026	1044	953	953
Total cold run time: 104113 ms
Total hot run time: 32583 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5372	5251	5268	5251
q2	275	333	256	256
q3	2210	2702	2310	2310
q4	1384	1764	1310	1310
q5	4380	4199	4857	4199
q6	227	198	155	155
q7	2252	1963	1765	1765
q8	2564	2408	2430	2408
q9	7531	7432	7534	7432
q10	2805	3004	2688	2688
q11	532	487	451	451
q12	685	738	626	626
q13	3967	4363	3377	3377
q14	287	306	312	306
q15	891	836	837	836
q16	683	732	695	695
q17	1143	1299	1449	1299
q18	8143	7691	7819	7691
q19	920	914	875	875
q20	2106	2132	2006	2006
q21	4959	4260	4143	4143
q22	1063	1050	979	979
Total cold run time: 54379 ms
Total hot run time: 51058 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.39 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f0da81dd5ae12bca98dbfbfab3a8f528bcaa0167, data reload: false

query1	0.05	0.05	0.04
query2	0.15	0.04	0.05
query3	0.27	0.09	0.08
query4	1.61	0.12	0.11
query5	0.26	0.25	0.24
query6	1.19	0.69	0.69
query7	0.04	0.03	0.03
query8	0.05	0.04	0.04
query9	0.58	0.50	0.49
query10	0.55	0.56	0.55
query11	0.17	0.10	0.10
query12	0.14	0.10	0.10
query13	0.64	0.61	0.62
query14	1.09	1.06	1.06
query15	0.88	0.86	0.87
query16	0.41	0.43	0.43
query17	1.18	1.16	1.15
query18	0.23	0.21	0.22
query19	2.12	2.05	2.10
query20	0.02	0.02	0.02
query21	15.40	0.28	0.14
query22	5.27	0.06	0.05
query23	16.15	0.30	0.10
query24	2.44	0.33	0.20
query25	0.13	0.06	0.06
query26	0.15	0.13	0.14
query27	0.06	0.06	0.06
query28	3.17	1.15	0.96
query29	12.64	3.83	3.15
query30	0.29	0.14	0.14
query31	2.81	0.62	0.41
query32	3.23	0.59	0.49
query33	3.28	3.27	3.32
query34	15.97	5.38	4.68
query35	4.76	4.82	4.77
query36	0.65	0.50	0.51
query37	0.14	0.07	0.07
query38	0.06	0.05	0.04
query39	0.06	0.03	0.03
query40	0.19	0.16	0.15
query41	0.10	0.03	0.03
query42	0.05	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 98.68 s
Total hot run time: 28.39 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 29, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit f18e2cb into apache:master Jan 29, 2026
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants