[enha]/auth introduction of ldaps support via configuration property #60275

iaorekhov-1980 · 2026-01-27T09:15:29Z

What problem does this PR solve?

This PR adds new configuration property ldap_use_ssl to enable usage of LDAPS to establish connection to LDAP instance.
If ldap_use_ssl in ldap.conf is specified as true - LDAPS is used to create connection string.
If ldap_use_ssl in ldap.conf is not specified or specified as false - LDAP is used to create connection string as now.

Could you please include this PR into 4.x and 3.1.x branches, please!

Issue Number: close #60236

Related PR: #xxx

Problem Summary:

Currently it is not possible to use LDAPS to create connection to secured LDAP instances.
New configuration property allows to connect to such instances, but default behavior still relies on LDAP as is.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.

ldap.conf and LdapConfig.java - new configuration ldap_use_ssl property added and static method to get actual URL connection string (this method was mostly introduced to support unit testing)
LdapClient.java - replaced explicit generation of URL connection string with call to new method in LDAP config
LdapClientTest.java - introduced new test method to validate existing behavior (without specified ldap_use_ssl property) and new one (with ldap_use_ssl property specified to true) to generate correct connection strings.

Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2026-01-27T09:15:41Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

iaorekhov-1980 · 2026-01-27T09:18:52Z

run buildall

iaorekhov-1980 · 2026-01-27T09:30:55Z

run buildall

iaorekhov-1980 · 2026-01-27T10:25:53Z

run feut

iaorekhov-1980 · 2026-01-27T10:45:32Z

run feut

iaorekhov-1980 · 2026-01-27T11:26:17Z

run feut

iaorekhov-1980 · 2026-01-27T13:06:04Z

run feut

iaorekhov-1980 · 2026-01-27T13:52:54Z

run feut

iaorekhov-1980 · 2026-01-27T14:14:18Z

run feut

hello-stephen · 2026-01-27T15:44:09Z

FE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

iaorekhov-1980 · 2026-01-27T15:45:04Z

run buildall

doris-robot · 2026-01-27T16:17:53Z

TPC-H: Total hot run time: 33048 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3974e9f14b99a306b890e8c7962e57d2e06752c9, data reload: false

------ Round 1 ----------------------------------
q1	17633	5234	5034	5034
q2	2023	332	196	196
q3	10203	1317	753	753
q4	10222	855	320	320
q5	7515	2162	1920	1920
q6	197	179	149	149
q7	900	765	594	594
q8	9257	1395	1180	1180
q9	5206	4843	4858	4843
q10	6741	1945	1564	1564
q11	527	285	271	271
q12	337	382	231	231
q13	17770	4065	3242	3242
q14	231	237	227	227
q15	878	834	807	807
q16	682	728	632	632
q17	639	770	482	482
q18	6898	6538	7539	6538
q19	1137	1026	676	676
q20	433	382	238	238
q21	2842	2473	2057	2057
q22	1128	1094	1146	1094
Total cold run time: 103399 ms
Total hot run time: 33048 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5528	5484	5452	5452
q2	262	340	279	279
q3	2351	2900	2537	2537
q4	1451	1918	1468	1468
q5	5117	4452	4656	4452
q6	233	189	137	137
q7	2032	1943	1855	1855
q8	2656	2493	2360	2360
q9	7521	7571	7353	7353
q10	2881	3178	2656	2656
q11	549	477	453	453
q12	680	762	635	635
q13	3875	4192	3188	3188
q14	273	306	262	262
q15	843	789	788	788
q16	624	701	630	630
q17	1085	1273	1298	1273
q18	7791	7415	7336	7336
q19	825	790	807	790
q20	1948	2053	1908	1908
q21	4486	4160	4055	4055
q22	1046	1014	962	962
Total cold run time: 54057 ms
Total hot run time: 50829 ms

doris-robot · 2026-01-27T16:34:42Z

ClickBench: Total hot run time: 28.47 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3974e9f14b99a306b890e8c7962e57d2e06752c9, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.05
query3	0.25	0.08	0.08
query4	1.61	0.11	0.11
query5	0.27	0.25	0.25
query6	1.16	0.69	0.67
query7	0.03	0.03	0.02
query8	0.05	0.03	0.03
query9	0.56	0.50	0.50
query10	0.56	0.54	0.54
query11	0.13	0.09	0.10
query12	0.14	0.10	0.10
query13	0.63	0.61	0.61
query14	1.05	1.07	1.06
query15	0.87	0.87	0.86
query16	0.41	0.40	0.41
query17	1.09	1.14	1.13
query18	0.23	0.21	0.22
query19	2.07	1.95	2.02
query20	0.02	0.02	0.02
query21	15.41	0.25	0.15
query22	5.31	0.06	0.05
query23	16.13	0.27	0.10
query24	1.52	0.34	0.39
query25	0.10	0.06	0.06
query26	0.15	0.14	0.14
query27	0.07	0.05	0.06
query28	3.55	1.14	0.96
query29	12.56	3.96	3.19
query30	0.28	0.13	0.15
query31	2.82	0.62	0.40
query32	3.23	0.59	0.49
query33	3.26	3.33	3.25
query34	16.36	5.40	4.78
query35	4.80	4.78	4.80
query36	0.64	0.50	0.49
query37	0.12	0.07	0.07
query38	0.08	0.04	0.04
query39	0.04	0.02	0.02
query40	0.18	0.16	0.16
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.03	0.03
Total cold run time: 98.07 s
Total hot run time: 28.47 s

hello-stephen · 2026-01-27T18:46:58Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

iaorekhov-1980 · 2026-01-27T18:59:37Z

run buildall

iaorekhov-1980 · 2026-01-27T19:11:57Z

run p0

doris-robot · 2026-01-27T19:37:12Z

TPC-H: Total hot run time: 32785 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3974e9f14b99a306b890e8c7962e57d2e06752c9, data reload: false

------ Round 1 ----------------------------------
q1	17639	5218	5047	5047
q2	2046	306	189	189
q3	10191	1357	761	761
q4	10225	907	341	341
q5	7561	2164	1959	1959
q6	197	181	150	150
q7	899	742	602	602
q8	9276	1494	1178	1178
q9	5212	4804	4832	4804
q10	6777	1966	1579	1579
q11	526	308	274	274
q12	341	381	229	229
q13	17766	4063	3289	3289
q14	265	237	212	212
q15	899	822	817	817
q16	686	677	608	608
q17	639	848	419	419
q18	6725	6593	6578	6578
q19	1284	980	614	614
q20	414	347	232	232
q21	2745	2123	1932	1932
q22	1024	1058	971	971
Total cold run time: 103337 ms
Total hot run time: 32785 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5259	5260	5210	5210
q2	256	327	262	262
q3	2259	2729	2312	2312
q4	1413	1827	1348	1348
q5	4240	4190	4632	4190
q6	248	201	156	156
q7	2203	2016	1882	1882
q8	2691	2415	2416	2415
q9	7570	7563	7505	7505
q10	2884	2976	2555	2555
q11	532	473	467	467
q12	698	746	647	647
q13	4224	4256	3637	3637
q14	315	318	294	294
q15	915	854	825	825
q16	673	705	675	675
q17	1198	1385	1466	1385
q18	8146	7875	7875	7875
q19	868	865	859	859
q20	2106	2240	1939	1939
q21	4571	4262	4103	4103
q22	1082	1015	986	986
Total cold run time: 54351 ms
Total hot run time: 51527 ms

doris-robot · 2026-01-27T19:53:59Z

ClickBench: Total hot run time: 28.41 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3974e9f14b99a306b890e8c7962e57d2e06752c9, data reload: false

query1	0.05	0.06	0.05
query2	0.10	0.04	0.05
query3	0.26	0.08	0.09
query4	1.60	0.12	0.11
query5	0.28	0.25	0.25
query6	1.16	0.67	0.67
query7	0.03	0.03	0.02
query8	0.05	0.04	0.04
query9	0.56	0.50	0.50
query10	0.54	0.55	0.54
query11	0.15	0.09	0.10
query12	0.13	0.10	0.10
query13	0.62	0.62	0.61
query14	1.08	1.05	1.07
query15	0.88	0.86	0.87
query16	0.42	0.38	0.40
query17	1.08	1.14	1.14
query18	0.22	0.20	0.20
query19	2.10	1.99	2.05
query20	0.02	0.01	0.02
query21	15.41	0.25	0.14
query22	5.52	0.05	0.05
query23	16.27	0.28	0.10
query24	1.42	1.00	0.41
query25	0.11	0.06	0.09
query26	0.14	0.13	0.13
query27	0.11	0.06	0.04
query28	4.40	1.14	0.97
query29	12.54	3.90	3.17
query30	0.26	0.13	0.12
query31	2.82	0.64	0.41
query32	3.24	0.59	0.50
query33	3.34	3.23	3.35
query34	16.21	5.37	4.71
query35	4.76	4.76	4.78
query36	0.65	0.51	0.50
query37	0.10	0.06	0.06
query38	0.07	0.05	0.04
query39	0.05	0.04	0.03
query40	0.20	0.16	0.15
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 99.14 s
Total hot run time: 28.41 s

hello-stephen · 2026-01-27T21:38:43Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2026-01-27T21:40:51Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

iaorekhov-1980 · 2026-01-27T21:43:35Z

run cloud_p0

hello-stephen · 2026-01-27T21:52:51Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

iaorekhov-1980 · 2026-01-27T21:53:51Z

run p0

hello-stephen · 2026-01-27T23:37:16Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2026-01-27T23:52:57Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

…ting

iaorekhov-1980 · 2026-01-28T05:07:34Z

run buildall

iaorekhov-1980 changed the title ~~Fix/ldaps support~~ [enha]/auth introduction of ldaps support via configuration property Jan 27, 2026

iaorekhov-1980 marked this pull request as draft January 27, 2026 09:18

iaorekhov-1980 force-pushed the fix/ldaps_support branch from e6954e3 to 59a60c2 Compare January 27, 2026 09:20

iaorekhov-1980 marked this pull request as ready for review January 27, 2026 09:20

iaorekhov-1980 force-pushed the fix/ldaps_support branch from 2dc20f8 to 2cc92da Compare January 27, 2026 11:15

iaorekhov-1980 force-pushed the fix/ldaps_support branch from 4452270 to c73cc70 Compare January 27, 2026 13:44

iaorekhov-1980 added 9 commits January 28, 2026 07:54

feat: add LDAPS support with configurable SSL/TLS connection

f67ea1d

added test for secure / insecure protocol

f34a6e9

fix: refactoring for url construction function

7a9be13

fix: missing import for code

ae55c34

fix: improve test logic for LDAP connection string

c07f48a

fix: refactoring getURL method to static one to enable unit testing

8736e04

fix: total refactoring of getConnectionURL method to support unit tes…

7d3f585

…ting

fix: extra space

d84c82b

fix: indentation

4169fc1

iaorekhov-1980 force-pushed the fix/ldaps_support branch from 3974e9f to 4169fc1 Compare January 28, 2026 04:54

[enha]/auth introduction of ldaps support via configuration property #60275

Are you sure you want to change the base?

[enha]/auth introduction of ldaps support via configuration property #60275

Conversation

iaorekhov-1980 commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

hello-stephen commented Jan 27, 2026

FE UT Coverage Report

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

doris-robot commented Jan 27, 2026

Uh oh!

doris-robot commented Jan 27, 2026

Uh oh!

hello-stephen commented Jan 27, 2026

FE Regression Coverage Report

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

doris-robot commented Jan 27, 2026

Uh oh!

doris-robot commented Jan 27, 2026

Uh oh!

hello-stephen commented Jan 27, 2026

FE Regression Coverage Report

Uh oh!

hello-stephen commented Jan 27, 2026

FE Regression Coverage Report

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

hello-stephen commented Jan 27, 2026

FE Regression Coverage Report

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

hello-stephen commented Jan 27, 2026

FE Regression Coverage Report

Uh oh!

hello-stephen commented Jan 27, 2026

FE Regression Coverage Report

Uh oh!

iaorekhov-1980 commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iaorekhov-1980 commented Jan 27, 2026 •

edited

Loading