Skip to content

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Jan 27, 2026

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Copilot AI review requested due to automatic review settings January 27, 2026 08:03
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables ADMIN SET TABLE ... PARTITION VERSION in cloud deployments by adding an explicit cloud-mode support check.

Changes:

  • Add checkSupportedInCloudMode(...) override to reject this command in cloud mode.
  • Update the command Javadoc to reflect the full SQL syntax.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jan 27, 2026

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32378 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7af25fa901a443c15bca85a447c4092f4da0e2bf, data reload: false

------ Round 1 ----------------------------------
q1	17642	5234	5048	5048
q2	2028	335	212	212
q3	10175	1290	749	749
q4	10201	785	303	303
q5	7529	2154	1905	1905
q6	194	183	147	147
q7	877	747	613	613
q8	9276	1377	1058	1058
q9	5147	4917	4798	4798
q10	6762	1954	1547	1547
q11	480	305	281	281
q12	339	376	223	223
q13	17764	4028	3199	3199
q14	235	246	221	221
q15	882	834	813	813
q16	679	677	607	607
q17	644	849	428	428
q18	6768	6440	6464	6440
q19	1234	984	613	613
q20	404	350	232	232
q21	2610	2049	2008	2008
q22	1040	971	933	933
Total cold run time: 102910 ms
Total hot run time: 32378 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5314	5274	5253	5253
q2	259	329	256	256
q3	2181	2690	2270	2270
q4	1379	1740	1324	1324
q5	4305	4248	4330	4248
q6	209	181	144	144
q7	2474	2006	1916	1916
q8	2595	2404	2391	2391
q9	7585	7395	7653	7395
q10	2824	3002	2652	2652
q11	587	501	460	460
q12	699	765	644	644
q13	3911	4603	3589	3589
q14	288	308	304	304
q15	854	823	823	823
q16	681	703	659	659
q17	1134	1334	1392	1334
q18	8500	7825	7872	7825
q19	878	841	838	838
q20	2096	2181	2089	2089
q21	4880	4375	4053	4053
q22	1025	1055	936	936
Total cold run time: 54658 ms
Total hot run time: 51403 ms

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add cloud_p0 case for it

@doris-robot
Copy link

ClickBench: Total hot run time: 28.16 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7af25fa901a443c15bca85a447c4092f4da0e2bf, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.04	0.04
query3	0.25	0.08	0.09
query4	1.60	0.11	0.11
query5	0.27	0.25	0.25
query6	1.19	0.67	0.67
query7	0.03	0.03	0.03
query8	0.05	0.03	0.04
query9	0.57	0.50	0.49
query10	0.55	0.55	0.54
query11	0.14	0.10	0.10
query12	0.13	0.10	0.10
query13	0.64	0.62	0.62
query14	1.06	1.04	1.05
query15	0.87	0.85	0.88
query16	0.40	0.38	0.40
query17	1.11	1.13	1.09
query18	0.22	0.21	0.21
query19	2.00	1.96	2.03
query20	0.02	0.01	0.01
query21	15.40	0.26	0.14
query22	4.87	0.06	0.05
query23	15.75	0.28	0.10
query24	1.67	0.23	0.54
query25	0.10	0.06	0.08
query26	0.14	0.14	0.13
query27	0.08	0.05	0.04
query28	4.15	1.15	0.97
query29	12.54	3.87	3.17
query30	0.28	0.13	0.11
query31	2.83	0.63	0.40
query32	3.24	0.61	0.49
query33	3.23	3.21	3.23
query34	16.30	5.41	4.71
query35	4.84	4.86	4.84
query36	0.66	0.50	0.48
query37	0.13	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.19	0.17	0.15
query41	0.09	0.03	0.04
query42	0.05	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 97.93 s
Total hot run time: 28.16 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jan 27, 2026

run buildall

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

TPC-H: Total hot run time: 32763 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9ae6f6ae3f28e1badfa2d5dad1d0cfd73b9e3302, data reload: false

------ Round 1 ----------------------------------
q1	17626	5221	5082	5082
q2	2067	347	193	193
q3	10145	1314	757	757
q4	10201	830	326	326
q5	7566	2080	1991	1991
q6	198	190	155	155
q7	892	753	615	615
q8	9264	1363	1112	1112
q9	5315	4892	4902	4892
q10	6770	1968	1560	1560
q11	534	305	280	280
q12	356	387	230	230
q13	17765	4004	3249	3249
q14	241	236	213	213
q15	908	828	801	801
q16	689	677	621	621
q17	648	827	442	442
q18	6847	6611	6552	6552
q19	1241	997	628	628
q20	394	356	235	235
q21	2608	2088	1892	1892
q22	1048	1018	937	937
Total cold run time: 103323 ms
Total hot run time: 32763 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5357	5334	5339	5334
q2	259	341	253	253
q3	2190	2645	2299	2299
q4	1344	1740	1295	1295
q5	4283	4130	4562	4130
q6	261	205	167	167
q7	2167	2028	1836	1836
q8	2540	2403	2433	2403
q9	7488	7561	7541	7541
q10	2773	2942	2606	2606
q11	551	474	487	474
q12	700	750	602	602
q13	3907	4366	3650	3650
q14	312	327	279	279
q15	840	807	826	807
q16	677	760	715	715
q17	1160	1459	1434	1434
q18	8019	8081	7957	7957
q19	899	851	853	851
q20	2101	2140	2032	2032
q21	4760	4536	4170	4170
q22	1049	1057	969	969
Total cold run time: 53637 ms
Total hot run time: 51804 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190701 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9ae6f6ae3f28e1badfa2d5dad1d0cfd73b9e3302, data reload: false

query5	4370	623	479	479
query6	318	214	204	204
query7	4211	443	248	248
query8	330	262	243	243
query9	8767	2792	2798	2792
query10	461	329	276	276
query11	16440	16291	16190	16190
query12	175	122	123	122
query13	1262	448	345	345
query14	6398	3203	2945	2945
query14_1	2772	2908	2745	2745
query15	203	190	175	175
query16	995	473	453	453
query17	1089	695	572	572
query18	2592	433	331	331
query19	207	184	160	160
query20	134	127	127	127
query21	221	145	125	125
query22	4934	5051	4866	4866
query23	19028	18523	18117	18117
query23_1	18496	18397	18432	18397
query24	7148	1604	1204	1204
query24_1	1195	1205	1200	1200
query25	558	463	418	418
query26	1238	276	147	147
query27	2767	446	276	276
query28	4538	1949	1953	1949
query29	813	545	444	444
query30	318	248	221	221
query31	874	752	676	676
query32	91	83	75	75
query33	544	359	315	315
query34	915	927	551	551
query35	743	805	694	694
query36	1138	1264	1021	1021
query37	142	107	94	94
query38	2964	2901	2885	2885
query39	939	928	915	915
query39_1	890	871	873	871
query40	225	134	122	122
query41	75	76	69	69
query42	93	102	96	96
query43	448	457	408	408
query44	1312	729	763	729
query45	192	188	181	181
query46	836	959	568	568
query47	2139	2112	2122	2112
query48	309	310	233	233
query49	597	425	339	339
query50	685	268	207	207
query51	4074	4071	4028	4028
query52	86	87	79	79
query53	206	219	163	163
query54	272	267	237	237
query55	81	78	73	73
query56	309	290	290	290
query57	1376	1384	1269	1269
query58	265	253	250	250
query59	2074	2117	2016	2016
query60	317	323	303	303
query61	152	145	143	143
query62	604	571	521	521
query63	192	167	162	162
query64	4881	1125	808	808
query65	4532	4439	4432	4432
query66	1404	443	340	340
query67	17965	17865	17776	17776
query68	2509	1007	650	650
query69	385	303	319	303
query70	972	967	957	957
query71	309	274	266	266
query72	5320	2409	3344	2409
query73	570	734	309	309
query74	9654	9675	9485	9485
query75	2503	2492	2041	2041
query76	2294	1060	660	660
query77	334	373	300	300
query78	11369	11488	10809	10809
query79	2110	899	549	549
query80	1676	509	433	433
query81	567	280	252	252
query82	1013	150	120	120
query83	349	262	242	242
query84	246	110	91	91
query85	871	461	403	403
query86	403	330	292	292
query87	3106	3121	2988	2988
query88	3489	2610	2592	2592
query89	388	326	280	280
query90	1981	183	185	183
query91	164	153	134	134
query92	76	72	71	71
query93	1145	961	578	578
query94	639	308	285	285
query95	578	334	309	309
query96	645	510	232	232
query97	2450	2512	2404	2404
query98	222	213	208	208
query99	937	950	828	828
Total cold run time: 267506 ms
Total hot run time: 190701 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.28 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9ae6f6ae3f28e1badfa2d5dad1d0cfd73b9e3302, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.25	0.08	0.08
query4	1.60	0.11	0.11
query5	0.29	0.24	0.25
query6	1.17	0.68	0.67
query7	0.03	0.03	0.02
query8	0.06	0.03	0.04
query9	0.56	0.50	0.50
query10	0.55	0.54	0.54
query11	0.14	0.09	0.10
query12	0.14	0.10	0.10
query13	0.64	0.61	0.61
query14	1.06	1.06	1.06
query15	0.88	0.85	0.88
query16	0.37	0.38	0.39
query17	1.08	1.14	1.07
query18	0.23	0.21	0.21
query19	2.10	1.97	1.96
query20	0.02	0.02	0.01
query21	15.41	0.28	0.14
query22	5.32	0.05	0.04
query23	15.89	0.30	0.10
query24	0.92	0.62	0.50
query25	0.08	0.08	0.08
query26	0.15	0.14	0.13
query27	0.06	0.05	0.06
query28	4.17	1.14	0.96
query29	12.56	3.89	3.13
query30	0.28	0.13	0.11
query31	2.81	0.64	0.42
query32	3.23	0.59	0.49
query33	3.20	3.22	3.26
query34	16.15	5.32	4.71
query35	4.82	4.78	4.72
query36	0.66	0.50	0.49
query37	0.11	0.06	0.06
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.16	0.14
query41	0.10	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 97.62 s
Total hot run time: 28.28 s

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jan 28, 2026

run p0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants