-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](cloud) AdminSetPartitionVersionCommand is unsupported in cloud mode #60263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[fix](cloud) AdminSetPartitionVersionCommand is unsupported in cloud mode #60263
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Disables ADMIN SET TABLE ... PARTITION VERSION in cloud deployments by adding an explicit cloud-mode support check.
Changes:
- Add
checkSupportedInCloudMode(...)override to reject this command in cloud mode. - Update the command Javadoc to reflect the full SQL syntax.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...main/java/org/apache/doris/nereids/trees/plans/commands/AdminSetPartitionVersionCommand.java
Show resolved
Hide resolved
...main/java/org/apache/doris/nereids/trees/plans/commands/AdminSetPartitionVersionCommand.java
Show resolved
Hide resolved
|
run buildall |
TPC-H: Total hot run time: 32378 ms |
morrySnow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add cloud_p0 case for it
ClickBench: Total hot run time: 28.16 s |
FE UT Coverage ReportIncrement line coverage |
|
run buildall |
FE Regression Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 32763 ms |
TPC-DS: Total hot run time: 190701 ms |
ClickBench: Total hot run time: 28.28 s |
|
run p0 |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)