fix: record join_time and output metrics in PiecewiseMergeJoin - #24689
Open
buraksenn wants to merge 1 commit into
Open
fix: record join_time and output metrics in PiecewiseMergeJoin#24689buraksenn wants to merge 1 commit into
join_time and output metrics in PiecewiseMergeJoin#24689buraksenn wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24689 +/- ##
==========================================
- Coverage 81.45% 81.45% -0.01%
==========================================
Files 1119 1119
Lines 400030 400182 +152
Branches 400030 400182 +152
==========================================
+ Hits 325850 325949 +99
- Misses 55144 55179 +35
- Partials 19036 19054 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jayzhan211
approved these changes
Aug 26, 2026
jayzhan211
left a comment
Contributor
There was a problem hiding this comment.
Thanks @buraksenn, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
EXPLAIN ANALYZEon aPiecewiseMergeJoinalways reportsjoin_time=0and, for classic joins,output_rows=0/output_bytes=0.0 B, so PWMJ plans can't be profiled like other joins.What changes are included in this PR?
join_time(started only after the streamed input's poll returnsReady) and record output metrics viarecord_polljoin_timecoverage for the scan and final passelapsed_computepicks both up via the existingBuildProbeJoinMetricsdropAre these changes tested?
Yes. Classic tests now assert
assert_join_metrics!, the existence final-pass test pinsjoin_time > 0, and a new test verifiesjoin_timeexcludes streamed-input wait.explain_analyze.sltshows the realoutput_bytes.Are there any user-facing changes?
No (PWMJ is experimental and off by default).