chore(ordered-partial-aggregate): move OrderedPartialAggregateStream to generators for readability - #23951
Open
rluvaton wants to merge 3 commits into
Open
chore(ordered-partial-aggregate): move OrderedPartialAggregateStream to generators for readability#23951rluvaton wants to merge 3 commits into
OrderedPartialAggregateStream to generators for readability#23951rluvaton wants to merge 3 commits into
Conversation
…` to generators for readability
rluvaton
marked this pull request as ready for review
July 28, 2026 20:10
Member
Author
|
@2010YOUY01 can you please run the benchmark that you think are the most appropriate here and review |
13 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23951 +/- ##
==========================================
+ Coverage 80.67% 80.69% +0.02%
==========================================
Files 1095 1095
Lines 372376 372447 +71
Branches 372376 372447 +71
==========================================
+ Hits 300397 300563 +166
+ Misses 54052 53913 -139
- Partials 17927 17971 +44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Simplify the code by making it linear and with less state to hold in mind
What changes are included in this PR?
change
OrderedPartialAggregateStreaminto async generatorsAre these changes tested?
existing tests
Are there any user-facing changes?
no