Skip to content

chore(ordered-partial-aggregate): move OrderedPartialAggregateStream to generators for readability - #23951

Open
rluvaton wants to merge 3 commits into
apache:mainfrom
rluvaton:move-ordered-partial-stream-to-async
Open

chore(ordered-partial-aggregate): move OrderedPartialAggregateStream to generators for readability#23951
rluvaton wants to merge 3 commits into
apache:mainfrom
rluvaton:move-ordered-partial-stream-to-async

Conversation

@rluvaton

@rluvaton rluvaton commented Jul 28, 2026

Copy link
Copy Markdown
Member

Which issue does this PR close?

N/A

Rationale for this change

Simplify the code by making it linear and with less state to hold in mind

What changes are included in this PR?

change OrderedPartialAggregateStream into async generators

Are these changes tested?

existing tests

Are there any user-facing changes?

no

@github-actions github-actions Bot added the physical-plan Changes to the physical-plan crate label Jul 28, 2026
@rluvaton
rluvaton requested a review from 2010YOUY01 July 28, 2026 20:08
@rluvaton
rluvaton marked this pull request as ready for review July 28, 2026 20:10
@rluvaton

Copy link
Copy Markdown
Member Author

@2010YOUY01 can you please run the benchmark that you think are the most appropriate here and review

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.40580% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.69%. Comparing base (1c3232c) to head (5c3ef5c).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...ical-plan/src/aggregates/ordered_partial_stream.rs 89.39% 0 Missing and 7 partials ⚠️
datafusion/physical-plan/src/aggregates/mod.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23951      +/-   ##
==========================================
+ Coverage   80.67%   80.69%   +0.02%     
==========================================
  Files        1095     1095              
  Lines      372376   372447      +71     
  Branches   372376   372447      +71     
==========================================
+ Hits       300397   300563     +166     
+ Misses      54052    53913     -139     
- Partials    17927    17971      +44     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants