minor(test): cover partially ordered aggregate spilling - #23947
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23947 +/- ##
==========================================
- Coverage 80.69% 80.69% -0.01%
==========================================
Files 1095 1095
Lines 372626 372697 +71
Branches 372626 372697 +71
==========================================
+ Hits 300700 300735 +35
- Misses 53978 53993 +15
- Partials 17948 17969 +21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2010YOUY01
left a comment
There was a problem hiding this comment.
LGTM, thank you!
This suggestion is totally optional, it would be great to move it to sqllogictest, due to 1. the test can be stronger as it exercises the behavior end-to-end 2. easier to maintain (I found rust tests regularly need updates during refactors, and they're harder to review)
To do that, sqllogictest provides Rust hooks to setup tables with orders, and we can use explain/explain analyzes to assert if the ordered path is triggered, and if spill happens.
Which issue does this PR close?
Rationale for this change
GroupedHashAggregateStreamsupports spilling for partially sorted group input, but existing aggregate spill tests only cover unordered (GroupOrdering::None) input. TheGroupOrdering::Partial+OutOfMemoryMode::Spillpath, including spilling sorted intermediate state and merging it back, does not have direct coverage.What changes are included in this PR?
added test coverage for the case above
Are these changes tested?
test only change and it can be tested via:
Are there any user-facing changes?
no test only change