perf: optimisation for date_part with seconds - #23444
Merged
Merged
Conversation
theirix
marked this pull request as ready for review
July 10, 2026 10:47
Contributor
|
run benchmark date_part |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing perf-date_part-seconds (a68f33a) to 1e77af8 (merge-base) diff using: date_part File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagedate_part — base (merge-base)
date_part — branch
File an issue against this benchmark runner |
Jefffrey
reviewed
Jul 11, 2026
Jefffrey
left a comment
Jefffrey
left a comment
Contributor
There was a problem hiding this comment.
do we have test coverage for date_part on date types?
| } | ||
|
|
||
| // Fast path for Date32 and Date64 - no seconds | ||
| match array.data_type() { |
Contributor
There was a problem hiding this comment.
if array.data_type() == &Date32 || array.data_type() == &Date64 {
return Ok(Arc::new(Int32Array::new(
vec![0; array.len()].into(),
array.nulls().cloned(),
)));
}applicable below too
Contributor
Author
There was a problem hiding this comment.
Now we do - added tests for date32/date64, and it allowed me to catch a bug
Contributor
There was a problem hiding this comment.
btw my above comment is a way to simplify the code
Jefffrey
approved these changes
Jul 14, 2026
Jefffrey
enabled auto-merge
July 14, 2026 10:24
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
date_partUDF optimisations #23351.Rationale for this change
Benches were added recently in #23350 . Improve and measure some optimisations.
What changes are included in this PR?
seconds_nsandseconds_as_i32. A pretty rare code path.Are these changes tested?
Are there any user-facing changes?