feat: implement make_time and to_time #4256
Draft
parthchandra wants to merge 3 commits intoapache:mainfrom
Draft
feat: implement make_time and to_time #4256parthchandra wants to merge 3 commits intoapache:mainfrom
parthchandra wants to merge 3 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3119, #3120
Rationale for this change
Spark 4.1 introduced TimeType along with make_time, to_time, and try_to_time expressions. This PR adds native Comet support for these expressions to avoid falling back to the JVM for time-related queries.
What changes are included in this PR?
make_time(hours, minutes, seconds)— constructs a TIME value from integer hours, minutes, and decimal seconds.to_time(string) /
try_to_time(string)— parses a string to a TIME value using Spark's default stringToTime format (no format-pattern variant yet).to_timeraises an error on unparseable input;try_to_timereturns nullInfrastructure for TimeType:
All expression interception is in the Spark 4.1/4.2 shims only — no impact on Spark 3.x/4.0 builds.
How are these changes tested?