chore: remove legacy ENABLE_COMET_SCAN_ONLY and ENABLE_COMET_ANSI_MODE env vars from Spark diffs#4252
Draft
parthchandra wants to merge 2 commits intoapache:mainfrom
Draft
chore: remove legacy ENABLE_COMET_SCAN_ONLY and ENABLE_COMET_ANSI_MODE env vars from Spark diffs#4252parthchandra wants to merge 2 commits intoapache:mainfrom
parthchandra wants to merge 2 commits intoapache:mainfrom
Conversation
…E env vars from Spark diffs These env vars are no longer set when running Spark SQL tests. ENABLE_COMET_SCAN_ONLY is removed from all diffs (always enable exec+shuffle). ENABLE_COMET_ANSI_MODE is removed from 3.4 and 3.5 diffs (ANSI mode has dedicated tests in the Spark SQL suite). Closes apache#2724 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These env vars are no longer set when running Spark SQL tests. ENABLE_COMET_SCAN_ONLY is removed from all diffs (always enable exec+shuffle). ENABLE_COMET_ANSI_MODE is removed from 3.4 and 3.5 diffs (ANSI mode has dedicated tests in the Spark SQL suite).
Which issue does this PR close?
Closes #2724
Rationale for this change
Removes unused env variables and cleans up diff files.
What changes are included in this PR?
ENABLE_COMET_SCAN_ONLYfrom all Spark diffs (3.4.3, 3.5.8, 4.0.2, 4.1.1) — this env var is no longer set when running Spark SQL tests, so the conditional logic is dead code. The "exec+shuffle enabled" path is now unconditional.ENABLE_COMET_ANSI_MODEfrom the 3.4.3 and 3.5.8 diffs — this only toggled spark.sql.ansi.enabled and doesn't enable any Comet features. ANSI mode already has dedicated tests in the Spark SQL suite.ParquetFilterSuiteguards from if (!isCometEnabled || isCometScanOnly)to if(!isCometEnabled).How are these changes tested?
CI