ci: reduce macOS PR matrix to single Spark 4.0 profile#4104
Open
andygrove wants to merge 1 commit intoapache:mainfrom
Open
ci: reduce macOS PR matrix to single Spark 4.0 profile#4104andygrove wants to merge 1 commit intoapache:mainfrom
andygrove wants to merge 1 commit intoapache:mainfrom
Conversation
Drop the Spark 3.4 / JDK 11 / Scala 2.12 and Spark 3.5 / JDK 17 / Scala 2.13 profiles from the macOS PR workflow, keeping only Spark 4.0 / JDK 17 / Scala 2.13. macOS runs cover platform-specific concerns (native library loading, FFI, threading, shuffle on Apple Silicon) that are largely independent of the Spark/Scala/JDK version. Full matrix coverage already happens on Linux. Reduces 21 jobs per PR to 7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4102 (Option A).
Rationale for this change
The macOS PR workflow currently runs 3 profiles (Spark 3.4 / JDK 11 / Scala 2.12, Spark 3.5 / JDK 17 / Scala 2.13, Spark 4.0 / JDK 17 / Scala 2.13) across 7 suites, for 21 jobs per PR. macOS runners cost roughly 2x Linux minutes, making this the most expensive workflow per job.
The macOS workflow exists primarily to catch platform-specific issues on Apple Silicon: native library loading, FFI, threading, and shuffle. Those concerns are largely independent of the Spark/Scala/JDK version. Full Spark/Java/Scala matrix coverage already happens on Linux in
pr_build_linux.yml, so running 3 Spark profiles on macOS is duplicative for everything that is not platform-sensitive.What changes are included in this PR?
Spark 3.4, JDK 11, Scala 2.12andSpark 3.5, JDK 17, Scala 2.13matrix entries from.github/workflows/pr_build_macos.yml, keeping onlySpark 4.0, JDK 17, Scala 2.13.sqlsuite under the Spark 3.4 profile.profileblock to explain the macOS-specific rationale.Reduces the macOS PR matrix from 21 jobs to 7.
How are these changes tested?
CI on this PR exercises the new matrix. If a regression slips through that depends on Spark version on macOS, we can add a second profile back.