test: enable SPARK-32509 DPP test for Spark 4.0#4100
Closed
andygrove wants to merge 1 commit intoapache:mainfrom
Closed
test: enable SPARK-32509 DPP test for Spark 4.0#4100andygrove wants to merge 1 commit intoapache:mainfrom
andygrove wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Partially addresses #4045.
Rationale for this change
The SPARK-32509 test in
DynamicPartitionPruningSuitewas disabled across all Spark versions under issue #4045. Re-running it on Spark 4.0.1 with Comet enabled now passes in all 6 concrete suite variants (V1/V2/V2Filter × AEOff/AEOn).What changes are included in this PR?
Removes the
IgnoreCometannotation from the SPARK-32509 test indev/diffs/4.0.1.diff. The companion SPARK-34637 test referenced by the sameIgnoreCometannotation remains ignored under #4045 since it still fails on Spark 4.0.1 with AQE enabled.The test was checked on Spark 3.5.8 as well but still fails there in
DynamicPartitionPruningV1SuiteAEOn, so the change is scoped to Spark 4.0 only.How are these changes tested?
Locally ran the test against the patched Spark 4.0.1 source with
ENABLE_COMET=true ENABLE_COMET_ONHEAP=true:All 6 variants pass.