Avoid possible serialization issues related to ArraySeq#1632
Merged
stevedlawrence merged 1 commit intoapache:mainfrom Feb 23, 2026
Merged
Conversation
The ArraySeq class has been known to cause deserialization failures related to saving/reloading parsers because the class is written in a way as to cause serialization sensitivity to changes in the class. We don't use ArraySeq in any of our serialized classes, but Scala implements varargs using ArraySeq, and we do use varargs in the serialized CompiledDPath class. This can make serialized objects sensitive to different versions of Scala if they make changes to the class. We do not need any of the features provided by ArraySeq or varargs, so this converts the ops member of CompiledDPath to an Array, avoiding potential deserialzation issues with future versions of Daffodil. DAFFODIL-3073
stevedlawrence
deleted the
daffodil-3073-varargs-serialization-compatibility
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ArraySeq class has been known to cause deserialization failures related to saving/reloading parsers because the class is written in a way as to cause serialization sensitivity to changes in the class.
We don't use ArraySeq in any of our serialized classes, but Scala implements varargs using ArraySeq, and we do use varargs in the serialized CompiledDPath class. This can make serialized objects sensitive to different versions of Scala if they make changes to the class.
We do not need any of the features provided by ArraySeq or varargs, so this converts the ops member of CompiledDPath to an Array, avoiding potential deserialzation issues with future versions of Daffodil.
DAFFODIL-3073