Skip to content

CXF-9116: Remove org.apache.cxf.feature.LoggingFeature #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
reta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CXF-9116: Remove org.apache.cxf.feature.LoggingFeature #2807

reta wants to merge 1 commit into from
+492 −2,081

Conversation

@reta
Copy link
Member

@reta reta commented Dec 28, 2025 •
edited
Loading

Remove org.apache.cxf.feature.LoggingFeature. It has been deprecated for a long time and should be removed, the replacement exists.

  • removed <logging> namespace handler in cxf-core (since logging feature is not part of core anymore): replacement is <bean class="org.apache.cxf.ext.logging.LoggingFeature"/> along with
     <dependency>
           <groupId>org.apache.cxf</groupId>
           <artifactId>cxf-rt-features-logging</artifactId>
           <version>4.2.0</version>
       </dependency>

@reta reta force-pushed the CXF-9116 branch 11 times, most recently from d1fe633 to a76b407 Compare December 29, 2025 14:05
@reta reta requested review from coheigea and ffang December 29, 2025 15:50
@reta
Copy link
Member Author

reta commented Dec 29, 2025

@coheigea @ffang would appreciate a look folks, getting rid of some long standing deprecations, thank you

reta
reta commented Dec 29, 2025
View reviewed changes
rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java

SecurityContext httpSecurityContext = new SecurityContext() {
final HttpServletRequest reqFromInMessage = (HttpServletRequest)exchange.getInMessage().get(HTTP_REQUEST);
final SecurityContext httpSecurityContext = new SecurityContext() {
Copy link
Member Author

@reta reta Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ffang some refactoring here: a number of cxf-*-security tests were failing due to logging change: apparently when DefaultLogEventMapper is called, the underlying HTTP request is already recycled and fails with NPE (jetty/jetty.project#12080). To mitigate that, at least for getUserPrincipal() - capturing principal early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ffang ffang Awaiting requested review from ffang

@coheigea coheigea Awaiting requested review from coheigea

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@reta