Skip to content

Fix UnsynchronizedByteArrayInputStream.skip() bounds and overflow - #924

Merged
garydgregory merged 1 commit into
apache:masterfrom
garydgregory:fix/UnsynchronizedByteArrayInputStream_skip_bounds
Nov 3, 2026
Merged

garydgregory merged 1 commit into
apache:masterfrom
garydgregory:fix/UnsynchronizedByteArrayInputStream_skip_bounds

Conversation

@garydgregory

Copy link
Copy Markdown
Member

Advance by the actual skipped count and return zero at EOF. Preserve negative-count rejection and document the skip contract.

Add regression tests for oversized counts, empty streams, bounded slices, mark/reset, and skipping after close.

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. ChatGpt 6 Astra.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

Advance by the actual skipped count and return zero at EOF.
Preserve negative-count rejection and document the skip contract.

Add regression tests for oversized counts, empty streams, bounded
slices, mark/reset, and skipping after close.
@garydgregory
garydgregory merged commit aa916ea into apache:master Nov 3, 2026
24 checks passed
@garydgregory
garydgregory deleted the fix/UnsynchronizedByteArrayInputStream_skip_bounds branch November 3, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant