Repository navigation
[IO-879] Restore read-only state after failed deletion - #881
Open
efegokdemir wants to merge 5 commits into
Open
efegokdemir wants to merge 5 commits into
efegokdemir wants to merge 5 commits into
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
|
One failure case appears to change the file state: AI assistance used. |
Member
|
@efegokdemir Please rebase on git master. |
garydgregory
changed the title
Restore the original file read-only state and parent POSIX permissions when deletion fails. Assisted-By: Codex
Restore each file and parent POSIX permissions independently, while retaining the original deletion failure if cleanup also fails. Add regressions for successful deletion, failed deletion and restoration errors. Assisted-By: OpenAI Codex
Attempt file and parent restoration independently and suppress restoration errors on the original deletion failure. Keep restoration errors visible after a successful deletion, with regression coverage for both paths. Assisted-By: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes IO-879 by restoring the file's original read-only state and the parent directory's POSIX permissions after an override-enabled deletion attempt. File and parent restoration are attempted independently, and restoration failures are suppressed on the original deletion exception.
Changes
Testing
mvn -B -ntp verify: 7,278 tests, 0 failures or errors, 41 skipped; JaCoCo passed.mvn -B -ntp checkstyle:check apache-rat:check: 0 Checkstyle violations; RAT passed.git diff --check: passed.AI assistance: OpenAI Codex assisted with implementation and regression tests.