Repository navigation
Refactor BinaryTree and ExplodingInputStream - #831
Open
fkjellberg wants to merge 1 commit into
Open
fkjellberg wants to merge 1 commit into
fkjellberg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.This PR separates reading the code lengths from building the tree, to prepare for replacing
BinaryTreewith theHuffmanDecoderin a follow-up PR.Changes
BinaryTree.decode(InputStream, int)is replaced byBinaryTree.fromCodeLengths(int[]). It builds the tree only from code lengths and checks that each length is in [1, 16].ExplodingInputStream.readCodeLengths(...), withreadBinaryTree(...)as a convenience wrapper.Fixes / behaviour changes
ArchiveException. Before, the missing entries were silently ignored. This aligns with the implementation found in the Info-ZIP UnZip 6.0 utility.Tests
fromCodeLengths(valid, empty and out-of-range lengths) and forreadCodeLengths(valid input, empty, truncated, too few and too many values).ExplodingInputStreamthat checks the decompressed output and theInputStreamStatisticscounters.