Repository navigation
Conversation
ecki
requested changes
Oct 29, 2026
ecki
left a comment
ecki
left a comment
Contributor
There was a problem hiding this comment.
Cn you please make the commit message English and not mention random numbers (I have no idea what they reference), I also have some other points.
|
|
||
| // Sort non-predefined attribute bands | ||
| final Comparator<NewAttributeBands> comparator = (arg0, arg1) -> arg0.getFlagIndex() - arg1.getFlagIndex(); | ||
| //Refactorizacion |
Contributor
There was a problem hiding this comment.
Please don’t comment that code is refactored
| } | ||
| return result; | ||
| } | ||
| private static BHSDCodec deriveTokenCodec(final int k, final int l) throws Pack200Exception { |
Contributor
There was a problem hiding this comment.
That’s a single use function?
| // key. | ||
| if (lastArray == array && lastKey == key) { | ||
| final boolean sameLookupAsLast = lastArray == array && Objects.equals(lastKey, key); | ||
| if (sameLookupAsLast) { |
Contributor
There was a problem hiding this comment.
Please don’t that doesnt make it much more readable
| "org.apache.commons.compress.harmony.archive.internal.nls.messages"; //$NON-NLS-1$ | ||
|
|
||
| static { | ||
| bundle = loadBundle(); |
| import java.util.ResourceBundle; | ||
|
|
||
| import java.util.logging.Level; | ||
| import java.util.logging.Logger; |
Contributor
There was a problem hiding this comment.
Is JUL used commonly in the project?
Member
|
-1 change for the sake of change. If you're looking for something to do, please see Jira. |
garydgregory
marked this pull request as draft
October 29, 2026 11:07
Member
|
Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactorización de code smells: tareas 10, 11, 14 y 15
Se implementaron cuatro refactorizaciones en Apache Commons Compress:
Comparator.comparingInt.Objects.equals.ResourceBundleen el métodoloadBundle().Validación: se ejecutó
mvn clean test-compilemediante Docker y la compilación finalizó conBUILD SUCCESS. También se ejecutógit diff --checksin errores.Rama de origen:
santiago.