-
Notifications
You must be signed in to change notification settings - Fork 1.3k
UI: Prevent extra API calls in search filter on scrolling #12553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Prevent extra API calls in search filter on scrolling #12553
Conversation
|
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12553 +/- ##
============================================
+ Coverage 4.16% 16.26% +12.09%
- Complexity 0 13427 +13427
============================================
Files 403 5660 +5257
Lines 32905 499917 +467012
Branches 5881 60698 +54817
============================================
+ Hits 1371 81318 +79947
- Misses 31360 409525 +378165
- Partials 174 9074 +8900
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
|
Verified the filter issues - mainly in Hosts view (displaying Type= in fliter) and filter uuid displayed instead of name on scrolling the view. |
c27ccb9 to
67c6bfa
Compare
|
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
UI build: ✔️ |
Description
This PR adds minor fixes on #12552
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?