Support dedicating backup offerings to domains #12194

Pearl1594 · 2025-12-04T17:20:47Z

Description

This PR allows dedicating backup offerings to domains to be consistent in behaviour with other offerings

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

…cate-backup-offering-to-domain

codecov · 2025-12-04T17:31:24Z

Codecov Report

❌ Patch coverage is 54.72313% with 139 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.79%. Comparing base (eedd329) to head (ce0d334).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java	63.88%	15 Missing and 11 partials ⚠️
...er/src/main/java/com/cloud/utils/DomainHelper.java	0.00%	19 Missing ⚠️
...e/cloudstack/backup/dao/BackupOfferingDaoImpl.java	0.00%	13 Missing ⚠️
...ver/src/main/java/com/cloud/acl/DomainChecker.java	47.61%	4 Missing and 7 partials ⚠️
.../api/command/offering/DomainAndZoneIdResolver.java	78.72%	0 Missing and 10 partials ⚠️
...c/main/java/com/cloud/user/AccountManagerImpl.java	0.00%	10 Missing ⚠️
.../command/admin/backup/ImportBackupOfferingCmd.java	0.00%	7 Missing ⚠️
...che/cloudstack/backup/BackupOfferingDetailsVO.java	75.00%	6 Missing and 1 partial ⚠️
...loudstack/api/response/BackupOfferingResponse.java	0.00%	6 Missing ⚠️
.../command/admin/backup/UpdateBackupOfferingCmd.java	37.50%	3 Missing and 2 partials ⚠️
... and 9 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12194      +/-   ##
============================================
+ Coverage     17.75%   17.79%   +0.03%     
- Complexity    15855    15910      +55     
============================================
  Files          5923     5927       +4     
  Lines        530536   530658     +122     
  Branches      64826    64835       +9     
============================================
+ Hits          94218    94434     +216     
+ Misses       425774   425652     -122     
- Partials      10544    10572      +28

Flag	Coverage Δ
uitests	`3.56% <ø> (-0.01%)`	⬇️
unittests	`18.88% <54.72%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pearl1594 · 2025-12-08T16:20:44Z

@blueorangutan package

blueorangutan · 2025-12-08T16:22:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-08T18:13:48Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15952

Pearl1594 · 2025-12-08T19:06:12Z

@blueorangutan test

blueorangutan · 2025-12-08T19:08:04Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-12-08T20:27:00Z

[SF] Trillian Build Failed (tid-14922)

blueorangutan · 2025-12-18T08:09:00Z

[SF] Trillian test result (tid-15019)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53399 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12194-t15019-kvm-ol8.zip
Smoke tests completed. 149 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	25.80	test_kubernetes_clusters.py

github-actions · 2025-12-22T13:48:38Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

…cate-backup-offering-to-domain

github-actions · 2026-01-07T08:07:52Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

RosiKyu · 2026-01-07T09:46:03Z

@blueorangutan package

blueorangutan · 2026-01-07T09:48:04Z

@RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-07T10:47:52Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16288

…cate-backup-offering-to-domain

Pearl1594 · 2026-01-07T10:58:59Z

@blueorangutan package

blueorangutan · 2026-01-07T11:00:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

Pearl1594 · 2026-01-07T11:08:58Z

@blueorangutan package

blueorangutan · 2026-01-07T11:10:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-07T11:12:24Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16289

blueorangutan · 2026-01-07T12:24:08Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16290

RosiKyu · 2026-01-07T14:11:19Z

@blueorangutan test

blueorangutan · 2026-01-07T14:12:05Z

@RosiKyu a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sonarqubecloud · 2026-01-07T18:14:36Z

Quality Gate passed

Issues
30 New issues
0 Accepted issues

Measures
0 Security Hotspots
42.7% Coverage on New Code
2.2% Duplication on New Code

See analysis details on SonarQube Cloud

RosiKyu · 2026-01-07T20:31:52Z

@blueorangutan package

blueorangutan · 2026-01-07T20:34:04Z

@RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-07T21:39:27Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16296

blueorangutan · 2026-01-08T06:09:48Z

[SF] Trillian test result (tid-15133)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54467 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12194-t15133-kvm-ol8.zip
Smoke tests completed. 149 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	26.92	test_kubernetes_clusters.py

RosiKyu

LGTM

Executed Test Cases (all PASSED):

Import Backup Offering with Single Domain Assignment
Import Backup Offering with Multiple Domain Assignment
Import Backup Offering Without Domain (Public)
Import Backup Offering with Duplicate Domain IDs
Import Backup Offering with Invalid Domain UUID
Update Backup Offering Domain Assignment
Update Backup Offering to Public Using 'public' Keyword
Update Backup Offering with Domain-Only Change
Update Backup Offering with Invalid Domain UUID
Update Backup Offering with Multiple Domains (Comma-Separated)
Backup Offerings as Root Admin
Backup Offerings as Domain User - See Only Allowed Offerings
List Backup Offerings as Domain Admin - See Only Allowed Offering
Response Contains Domain Information
Assign VM to Backup Offering - Allowed Domain
Assign VM to Backup Offering - Denied for Other Domain
Create Backup Schedule - Allowed Domain
Create Backup Schedule - Denied for Other Domain
Adhoc Backup - Denied for Other Domain Offering
Filter Child Subdomains in Domain List
Import Backup Offering with Domain Selector
Domain Assignment Displayed in Backup Offering List
Filter Offerings by User Domain
Root Admin Sees All Offerings
Domain Assignment in Offering Details View
Domain Selector Only Visible to Admins
No Domain Update in Edit Form
Backup Offerings Accessible via Service Offerings Menu
Backward Compatibility - Existing Offerings Remain Public
No Regression - Network Offering Domain Updates
No Regression - Disk Offering Domain Updates
Database Schema Migration
Centralized Access Control Check
No Regression - Compute Offering Domain Updates
No Regression - VPC Offering Domain Updates
No Regression - System Offering Domain Updates
Parity with Other Offering Types
Smoketests
Upgrade from previous released version
PR Mergable
Cloudstack Style
Code coverage criteria

Pearl1594 added 3 commits November 25, 2025 12:07

Add support for dedicating backup offerings to domains

7385d8c

Add tests and UI support and update response params

21bc89e

Merge branch 'main' of https://github.com/apache/cloudstack into dedi…

6df6440

…cate-backup-offering-to-domain

boring-cyborg bot added component:api component:backup component:marvin component:networking component:UI component:vpc Python Warning... Python code Ahead! labels Dec 4, 2025

add license header

a0844fe

exclude backupofferingdetailsvo from sonar

b4a8034

boring-cyborg bot added the component:build label Dec 4, 2025

Pearl1594 closed this Dec 4, 2025

Pearl1594 reopened this Dec 4, 2025

Pearl1594 added 2 commits December 5, 2025 10:00

fix pre-commit checks - missing / extra EOF line

34844c0

add test

af06a08

Pearl1594 closed this Dec 5, 2025

Pearl1594 reopened this Dec 5, 2025

EOF

30ce121

Pearl1594 added 2 commits December 8, 2025 18:37

filter backup offerings by domain id

39dacc3

add unit tests

a063e94

Pearl1594 closed this Dec 8, 2025

github-actions bot added the status:has-conflicts label Dec 22, 2025

Merge branch 'main' of https://github.com/apache/cloudstack into dedi…

890659a

…cate-backup-offering-to-domain

github-actions bot removed the status:has-conflicts label Jan 5, 2026

Pearl1594 added 2 commits January 5, 2026 08:21

add unit tests to increase coverage

738ffd7

pre-commit check failure fix

64e8bb7

github-actions bot added the status:has-conflicts label Jan 7, 2026

Merge branch 'main' of https://github.com/apache/cloudstack into dedi…

3f273a2

…cate-backup-offering-to-domain

github-actions bot removed the status:has-conflicts label Jan 7, 2026

address merge issue

76929ab

allow updating backup offering when only domain id is modified

ce0d334

RosiKyu approved these changes Jan 8, 2026

View reviewed changes

Support dedicating backup offerings to domains #12194

Are you sure you want to change the base?

Support dedicating backup offerings to domains #12194

Conversation

Pearl1594 commented Dec 4, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pearl1594 commented Dec 8, 2025

Uh oh!

blueorangutan commented Dec 8, 2025

Uh oh!

blueorangutan commented Dec 8, 2025

Uh oh!

Pearl1594 commented Dec 8, 2025

Uh oh!

blueorangutan commented Dec 8, 2025

Uh oh!

blueorangutan commented Dec 8, 2025

Uh oh!

blueorangutan commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

RosiKyu commented Jan 7, 2026

Uh oh!

blueorangutan commented Jan 7, 2026

Uh oh!

blueorangutan commented Jan 7, 2026

Uh oh!

Pearl1594 commented Jan 7, 2026

Uh oh!

blueorangutan commented Jan 7, 2026

Uh oh!

Pearl1594 commented Jan 7, 2026

Uh oh!

blueorangutan commented Jan 7, 2026

Uh oh!

blueorangutan commented Jan 7, 2026

Uh oh!

blueorangutan commented Jan 7, 2026

Uh oh!

RosiKyu commented Jan 7, 2026

Uh oh!

blueorangutan commented Jan 7, 2026

Uh oh!

sonarqubecloud bot commented Jan 7, 2026

Quality Gate passed

Uh oh!

RosiKyu commented Jan 7, 2026

Uh oh!

blueorangutan commented Jan 7, 2026

Uh oh!

blueorangutan commented Jan 7, 2026

Uh oh!

blueorangutan commented Jan 8, 2026

Uh oh!

RosiKyu left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Dec 4, 2025 •

edited

Loading