-
Notifications
You must be signed in to change notification settings - Fork 119
Allow copy of templates from secondary storages of same or other zone when adding a new secondary storage #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
…y added secondary storage
| | | when adding a new Secondary Storage, instead of downloading them from the source URL. | | | ||
| +----------------------------------------------+-------------------------------------------------------------------------------------------------------------+-----------+ | ||
|
|
||
| This setting is enabled by default and can be configured globally or at zone level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when creating a zone it is enabled by default, so preventing it will be hard right? A race against the machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point Daan. When creating a zone, it uses the global setting (not zone level). I also want to keep the default value to false to keep it backward compatible. But the first PR is already merged apache/cloudstack#10363, I can do that change in my subsequent PR apache/cloudstack#12296
One another point to note, if the setting is enabled, first it attempts to copy from secondary storage, if it fails then it fall back to old behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not mind enabling by default, just something to be aware of (and maybe document here). If useful to alternate we may wat to add a switch to the zone wizard (i.e set it before enabling the zone)
|
@blueorangutan docbuild |
|
@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
|
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/611. (QA-JID 470) |
abh1sar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
some nitpicks regarding capitalisations.
| - Path. The path to the zone's Secondary Staging Store. | ||
| - Path: The path to the zone's Secondary Staging Store. | ||
|
|
||
| - Copy templates from other storages: This switch can be used to automatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Copy templates from other storages: This switch can be used to automatically | |
| - **Copy Templates from other storages**: This switch can be used to automatically |
Could you also put the other fields in bold (if not already)
| - Path: The path to the zone's Secondary Staging Store. | ||
|
|
||
| - Copy templates from other storages: This switch can be used to automatically | ||
| copy existing templates from secondary storages in other zones instead of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| copy existing templates from secondary storages in other zones instead of | |
| copy existing Templates from Secondary Storages in other Zones instead of |
|
|
||
|
|
||
| When a new Secondary Storage is added, the Management Server attempts to make | ||
| existing templates available on the new Secondary Storage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| existing templates available on the new Secondary Storage. | |
| existing Templates available on the new Secondary Storage. |
| When a new Secondary Storage is added, the Management Server attempts to make | ||
| existing templates available on the new Secondary Storage. | ||
|
|
||
| CloudStack improves template availability using the configuration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| CloudStack improves template availability using the configuration: | |
| CloudStack improves Template availability using the configuration: |
| +----------------------------------------------+-------------------------------------------------------------------------------------------------------------+-----------+ | ||
| | Name | Description | Default | | ||
| +==============================================+=============================================================================================================+===========+ | ||
| | copy.templates.from.other.secondary.storages | Allow templates to be copied from existing Secondary Storage servers (within the same zone or across zones) | true | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | copy.templates.from.other.secondary.storages | Allow templates to be copied from existing Secondary Storage servers (within the same zone or across zones) | true | | |
| | copy.templates.from.other.secondary.storages | Allow Templates to be copied from existing Secondary Storage servers (within the same zone or across zones) | true | |
|
|
||
| 1. Attempt to copy the template from another Secondary Storage in the same zone. | ||
| 2. If not found, attempt to copy the template from a Secondary Storage in a different zone. | ||
| 3. If the copy operation fails, CloudStack falls back to downloading the template using its URL when it is registered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 3. If the copy operation fails, CloudStack falls back to downloading the template using its URL when it is registered. | |
| 3. If the copy operation fails, CloudStack falls back to downloading the Template using its URL when it is registered. |
| storage in each zone is still required. | ||
|
|
||
| - Zone. The zone where the NFS Secondary Staging Store is to be | ||
| - Zone: The zone where the NFS Secondary Staging Store is to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Zone: The zone where the NFS Secondary Staging Store is to be | |
| - **Zone**: The Zone where the NFS Secondary Staging Store is to be. |
|
|
||
| #. Fill in the following fields: | ||
|
|
||
| - Name. Give the storage a descriptive name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - **Name**: Give the storage a descriptive name. |
|
|
||
| - Name. Give the storage a descriptive name. | ||
|
|
||
| - Provider. Choose S3, Swift, NFS, or CIFS then fill in the related |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - **Provider**: Choose S3, Swift, NFS, or CIFS then fill in the related |
| Heterogeneous Secondary Storage is not supported in Regions. You can | ||
| use only a single NFS, S3, or Swift account per region. | ||
|
|
||
| - Create NFS Secondary Staging Store. This box must always be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - **Create NFS Secondary Staging Store**: This box must always be |
This document is in relation to the PRs apache/cloudstack#10363 and apache/cloudstack#12296
📚 Documentation preview 📚: https://cloudstack-documentation--611.org.readthedocs.build/en/611/