Skip to content

Test case for [CALCITE-4792] SqlToRel should populate corralateId for join with corralated query in ON condition #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuzifu666 merged 1 commit into from
Aug 7, 2026
+51 −0
Merged

Test case for [CALCITE-4792] SqlToRel should populate corralateId for join with corralated query in ON condition #5160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,17 @@ public static void checkActualAndReferenceFiles() {
sql(sql).withExpand(false).ok();
}

/** Test case for
* <a href="https://issues.apache.org/jira/browse/CALCITE-4792">[CALCITE-4792]
* SqlToRel should populate corralateId for join with corralated query in ON condition</a>.
*/
@Test void testJoinOnCorrelatedSubQuery() {
final String sql = "select * from emp inner join dept\n"
+ "on emp.deptno = dept.deptno\n"
+ "and exists (select 1 from emp e2 where e2.deptno = dept.deptno)";
sql(sql).withExpand(false).ok();
}

@Test void testJoinUsing() {
sql("SELECT * FROM emp JOIN dept USING (deptno)").ok();
}
Expand Down
18 changes: 18 additions & 0 deletions core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4345,6 +4345,24 @@ LogicalValues(tuples=[[{ 1 }, { 2 }, { 3 }, { 4 }, { 5 }, { 6 }, { 7 }, { 8 }, {
}))], joinType=[left])
LogicalValues(tuples=[[{ 1, 'a' }, { 2, 'b' }]])
LogicalValues(tuples=[[{ 1, 'a' }, { 2, 'b' }]])
]]>
</Resource>
</TestCase>
<TestCase name="testJoinOnCorrelatedSubQuery">
<Resource name="sql">
<![CDATA[select * from emp inner join dept
on emp.deptno = dept.deptno
and exists (select 1 from emp e2 where e2.deptno = dept.deptno)]]>
</Resource>
<Resource name="plan">
<![CDATA[
LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4], SAL=[$5], COMM=[$6], DEPTNO=[$7], SLACKER=[$8], DEPTNO0=[$9], NAME=[$10])
LogicalJoin(condition=[AND(=($7, $9), EXISTS({
LogicalFilter(condition=[=($7, $cor0.DEPTNO0)])
LogicalTableScan(table=[[CATALOG, SALES, EMP]])
}))], joinType=[inner], variablesSet=[[$cor0]])
LogicalTableScan(table=[[CATALOG, SALES, EMP]])
LogicalTableScan(table=[[CATALOG, SALES, DEPT]])
]]>
</Resource>
</TestCase>
Expand Down
22 changes: 22 additions & 0 deletions core/src/test/resources/sql/sub-query.iq
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10110,5 +10110,27 @@ WHERE E1.SAL > (SELECT B1.COMM FROM BONUS B1 WHERE E1.ENAME = B1.ENAME LIMIT 2);
+--------+
(0 rows)

!ok

# [CALCITE-4792] SqlToRel should populate corralateId for join with corralated query in ON condition.
SELECT emp.ename, dept.dname

@xuzifu666 xuzifu666 Aug 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated in PostgreSQL: https://onecompiler.com/postgresql/44xdzzumu

FROM emp INNER JOIN dept
ON emp.deptno = dept.deptno
AND EXISTS (SELECT 1 FROM emp e2 WHERE e2.deptno = dept.deptno AND e2.sal > 2900)
ORDER BY emp.ename;
+--------+------------+
| ENAME | DNAME |
+--------+------------+
| ADAMS | RESEARCH |
| CLARK | ACCOUNTING |
| FORD | RESEARCH |
| JONES | RESEARCH |
| KING | ACCOUNTING |
| MILLER | ACCOUNTING |
| SCOTT | RESEARCH |
| SMITH | RESEARCH |
+--------+------------+
(8 rows)

!ok
# End sub-query.iq
Loading