[CALCITE-7676] Exclude constant literals from GROUP BY ALL / ORDER BY ALL keys - #5127
Open
tisyabhatia wants to merge 1 commit into
Open
[CALCITE-7676] Exclude constant literals from GROUP BY ALL / ORDER BY ALL keys#5127tisyabhatia wants to merge 1 commit into
tisyabhatia wants to merge 1 commit into
Conversation
Contributor
|
I guess you did not read the comment I left on the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to CALCITE-7594 / CALCITE-7597. GROUP BY ALL / ORDER BY ALL expanded every non-aggregate SELECT expression into the implicit keys, including bare constant literals — so e.g.
SELECT count(*), 42 ... GROUP BY ALLmaterializedGROUP BY 42, which re-parses as an out-of-range ordinal on the view / materialized-table unparse round-trip. ExcludesSqlLiteralkeys (grouping/sorting by a constant is a no-op; only bare literals, not compound constant expressions). Adds rewritesTo tests. See CALCITE-7676.