Skip to content

[CALCITE-7388] Redis Adapter operand config should not support empty string #4756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xuzifu666 merged 1 commit into from
Jan 22, 2026
Merged

[CALCITE-7388] Redis Adapter operand config should not support empty string #4756

xuzifu666 merged 1 commit into from
Jan 22, 2026
+219 −8

Conversation

@cjj2010
Copy link

@cjj2010 cjj2010 commented Jan 20, 2026 •
edited
Loading

@mihaibudiu
Copy link
Contributor

mihaibudiu commented Jan 20, 2026

The style checks require some simple changes to your comments.
You can get the reports from CI or by running ./gradlew build locally.

xuzifu666
xuzifu666 reviewed Jan 21, 2026
View reviewed changes
Copy link
Member

@xuzifu666 xuzifu666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

@cjj2010
Copy link
Author

cjj2010 commented Jan 21, 2026

The style checks require some simple changes to your comments. You can get the reports from CI or by running ./gradlew build locally.

Thank you for the reminder, it has been fixed

@xuzifu666
Copy link
Member

xuzifu666 commented Jan 22, 2026

CI is not happy，should not related to your changes，I rerun it.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 22, 2026

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

xuzifu666
xuzifu666 approved these changes Jan 22, 2026
View reviewed changes
Copy link
Member

@xuzifu666 xuzifu666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can squash commits to one.
Please make sure the commit information and Jira information are completely consistent.

@mihaibudiu mihaibudiu added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Jan 22, 2026
@cjj2010 cjj2010 force-pushed the redis-adapter-config branch from 72617b8 to a06e42b Compare January 22, 2026 07:08
@cjj2010
Copy link
Author

cjj2010 commented Jan 22, 2026

You can squash commits to one. Please make sure the commit information and Jira information are completely consistent.

done

@xuzifu666 xuzifu666 merged commit 6fab1a1 into apache:main Jan 22, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xuzifu666 xuzifu666 xuzifu666 approved these changes

Assignees

No one assigned

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cjj2010 @mihaibudiu @xuzifu666