[CALCITE-4765] Complex correlated EXISTS sub-queries used as scalar subqueries can return wrong results

[xiedeyantu]

See CALCITE-4765

Only add tests.

[xiedeyantu]

@NobiGo If you have time, could you please check if it's working correctly now? Since I couldn't find an emps table containing commission in quidem test, I've temporarily replaced it with emp from scott.

[mihaibudiu]

The CI is unhappy for some reason too

[xiedeyantu]

The CI is unhappy for some reason too

Fixed, thanks!

[xiedeyantu]

This is the result compared with PGSQL.

[xiedeyantu]

I tried constructing emps and resubmitting the test.

[mihaibudiu]

This is the result compared with PGSQL.

Is this the right link?

[xiedeyantu]

This is the result compared with PGSQL.

Is this the right link?

Sorry, I have updated the original SQL to the SQL in the current PR.

[xiedeyantu]

@NobiGo @mihaibudiu I have file a new jira CALCITE-7356 to describe it.

[xiedeyantu]

Since #4752 has been merged, this issue no longer exists, and I have updated the test.

[silundong]

LGTM. It seems the CI error is not related to the changes.

[NobiGo]

I hope we can add a test case in SqlToRelTest. It's not necessary to have completely identical metadata; using existing table names is fine, and this test case can clearly show how $cor0 is defined.

[xiedeyantu]

I hope we can add a test case in SqlToRelTest. It's not necessary to have completely identical metadata; using existing table names is fine, and this test case can clearly show how $cor0 is defined.

If you find the name confusing, can I change emps to emps_tmp?

[NobiGo]

I hope we can add a test case in SqlToRelTest. It's not necessary to have completely identical metadata; using existing table names is fine, and this test case can clearly show how $cor0 is defined.

If you find the name confusing, can I change emps to emps_tmp?

I suggest adding test cases to SqlToRelTest. You can directly use the metadata from SqlToRelTest instead of simulating the same table and column names.The current test cases in .iq are fine for me.

[xiedeyantu]

I hope we can add a test case in SqlToRelTest. It's not necessary to have completely identical metadata; using existing table names is fine, and this test case can clearly show how $cor0 is defined.

If you find the name confusing, can I change emps to emps_tmp?

I suggest adding test cases to SqlToRelTest. You can directly use the metadata from SqlToRelTest instead of simulating the same table and column names.The current test cases in .iq are fine for me.

I have added test cases and change the table name in blank.iq; please check if they meet your requirements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud