[SolaceIO] refactor SolaceIO's writers finishBundle - #39612
Conversation
…shed persistent messages have received either an acknowledgment (ACK) or a negative acknowledgment (NACK/error) from the Solace broker, up to a timeout.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Assigning reviewers: R: @kennknowles for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| publishResults(context, messageIdsToAck); | ||
| if (!messageIdsToAck.isEmpty()) { | ||
| try { | ||
| Thread.sleep(10); |
There was a problem hiding this comment.
This will increase my project's test suite run by 10x :) Maybe this could be done without sleep, e.g. the waiting thread is woken up as soon as Solace callback with the ack arrives, and then checks the ack queue.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39612 +/- ##
============================================
+ Coverage 58.12% 58.13% +0.01%
- Complexity 13086 13089 +3
============================================
Files 2521 2522 +1
Lines 264308 264352 +44
Branches 10786 10788 +2
============================================
+ Hits 153616 153670 +54
+ Misses 104922 104919 -3
+ Partials 5770 5763 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Refactor SolaceIO's writers to block in @FinishBundle until all published persistent messages have received either an acknowledgment (ACK) or a negative acknowledgment (NACK/error) from the Solace broker, up to a timeout.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.