Skip to content

[SolaceIO] refactor SolaceIO's writers finishBundle - #39612

Open
stankiewicz wants to merge 2 commits into
apache:masterfrom
stankiewicz:solace_writer_wait_for_response
Open

[SolaceIO] refactor SolaceIO's writers finishBundle#39612
stankiewicz wants to merge 2 commits into
apache:masterfrom
stankiewicz:solace_writer_wait_for_response

Conversation

@stankiewicz

Copy link
Copy Markdown
Contributor

Refactor SolaceIO's writers to block in @FinishBundle until all published persistent messages have received either an acknowledgment (ACK) or a negative acknowledgment (NACK/error) from the Solace broker, up to a timeout.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

…shed persistent messages have received either an acknowledgment (ACK) or a negative acknowledgment (NACK/error) from the Solace broker, up to a timeout.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@stankiewicz stankiewicz changed the title [SolaceIO] refactor SolaceIO's writers finishBunlde [SolaceIO] refactor SolaceIO's writers finishBundle Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @kennknowles for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

publishResults(context, messageIdsToAck);
if (!messageIdsToAck.isEmpty()) {
try {
Thread.sleep(10);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will increase my project's test suite run by 10x :) Maybe this could be done without sleep, e.g. the waiting thread is woken up as soon as Solace callback with the ack arrives, and then checks the ack queue.

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.13%. Comparing base (4fd1744) to head (a1173bb).
⚠️ Report is 96 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #39612      +/-   ##
============================================
+ Coverage     58.12%   58.13%   +0.01%     
- Complexity    13086    13089       +3     
============================================
  Files          2521     2522       +1     
  Lines        264308   264352      +44     
  Branches      10786    10788       +2     
============================================
+ Hits         153616   153670      +54     
+ Misses       104922   104919       -3     
+ Partials       5770     5763       -7     
Flag Coverage Δ
java 64.26% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants