Adds a new CoderTranslator for Java SchemaCoders. - #39594
Conversation
… a timer caused by drain. We then pass the residual restriction (if present) to ProcessElement.
This reverts commit 357fd26.
…er experiment instead of version compatibility number.
…hanges to this PR.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers: R: @ahmedabu98 for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| @Override | ||
| public boolean isKnownCoder(Coder<?> coder, PipelineOptions options) { | ||
| if (coder.getClass() == SchemaCoder.class | ||
| && !ExperimentalOptions.hasExperiment(options, "use_known_schema_coder")) { |
There was a problem hiding this comment.
Since we have pipeline options now, we can check runner capability to translate to use SchemaCoder only when runner supported it. Then we don't need to worry about breaking changes on different runners for now.
The new translator splits out the Schema proto from the toRowFn and fromRowFn's so that runners can check the Schema proto for compatibility updates such as reordering fields. Previously, the coder was simply translated as a custom java coder, which runners couldn't reason about.
Since this is a potentially backwards incompatible change, this new coder format is guarded by the "use_known_schema_coder" PipelineOptions experiment.
This fixes a few issues related to Schemas and pipeline updates: addresses #36496, #30276, #29245.
This PR is essentially a roll forward of the rollback #38514 with the change protected by experiment instead of using the pipeline compatibility version number.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.