Skip to content

GH-49921: [C++] Bump xsimd to 14.2.0#49922

Open
AntoinePrv wants to merge 3 commits intoapache:mainfrom
AntoinePrv:main
Open

GH-49921: [C++] Bump xsimd to 14.2.0#49922
AntoinePrv wants to merge 3 commits intoapache:mainfrom
AntoinePrv:main

Conversation

@AntoinePrv
Copy link
Copy Markdown
Contributor

@AntoinePrv AntoinePrv commented May 5, 2026

Rationale for this change

What changes are included in this PR?

Bump version and cleanup backports.

Are these changes tested?

Yes, in CI.

Are there any user-facing changes?

No

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

⚠️ GitHub issue #49921 has been automatically assigned in GitHub to PR creator.

@AntoinePrv AntoinePrv changed the title GH-49921: [C++] Bunp xsimd to 14.2.0 GH-49921: [C++] Bump xsimd to 14.2.0 May 5, 2026
@pitrou
Copy link
Copy Markdown
Member

pitrou commented May 6, 2026

@AntoinePrv Can you take a look at the CI failures? They seem related.

@AntoinePrv
Copy link
Copy Markdown
Contributor Author

Yes, I am still waiting for the Msys2 build of xsimd to happen...

@pitrou
Copy link
Copy Markdown
Member

pitrou commented May 6, 2026

@AntoinePrv
Copy link
Copy Markdown
Contributor Author

AntoinePrv commented May 6, 2026

Perhaps it's this check that does not work on MSVC?

https://github.com/xtensor-stack/xsimd/blob/80c23624ce008d937da7e845e528e82ce0cbf4e0/include/xsimd/types/xsimd_batch_constant.hpp#L500

Either we could add /Zc:__cplusplus or re-introduce the backport.

@pitrou
Copy link
Copy Markdown
Member

pitrou commented May 6, 2026

I think we should both 1) fix xsimd upstream anyway and 2) pass /Zc:__cplusplus when building Arrow C++.

It seems xsimd should do something like this:

#ifdef _MSVC_LANG
#define XSIMD_CPP_LEVEL _MSVC_LANG
#else
#define XSIMD_CPP_LEVEL __cplusplus
#endif

and then use the XSIMD_CPP_LEVEL macro everywhere instead of __cplusplus.

(but xsimd could also use find-grained feature testing).

@AntoinePrv
Copy link
Copy Markdown
Contributor Author

AntoinePrv commented May 6, 2026

Already sending a patch, but not sure I want to go through another round of xsimd releases

xtensor-stack/xsimd#1342

@pitrou
Copy link
Copy Markdown
Member

pitrou commented May 6, 2026

Agreed, hence "pass /Zc:__cplusplus when building Arrow C++" as well 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants