GH-48575: [C++][FlightRPC] Standalone ODBC macOS CI #48577

alinaliBQ · 2025-12-17T22:21:44Z

Rationale for this change

#48575

What changes are included in this PR?

Add new ODBC workflow for macOS Intel 15 and 14 arm64.
Added ODBC build fixes to enable build on macOS CI.

Are these changes tested?

Tested in CI and local macOS Intel and M1 environments.

Are there any user-facing changes?

N/A

GitHub Issue: [C++][FlightSQL][ODBC] macOS ODBC standalone CI #48575

github-actions · 2025-12-17T22:22:09Z

⚠️ GitHub issue #48575 has been automatically assigned in GitHub to PR creator.

Co-Authored-By: justing-bq <[email protected]> Co-Authored-By: Victor Tsang <[email protected]> Co-Authored-By: Alina (Xi) Li <[email protected]>

Co-Authored-By: alinalibq <[email protected]> Co-Authored-By: justing-bq <[email protected]>

added changes to build in MacOS Co-authored-by: vic-tsang <[email protected]>

alinaliBQ · 2025-12-19T22:49:15Z

ci/scripts/cpp_build.sh

    -DCMAKE_C_FLAGS="${CFLAGS:-}" \
-    -DCMAKE_CXX_FLAGS="${CXXFLAGS:-}" \
+    -DCMAKE_CXX_FLAGS="${CXXFLAGS:-} -I${ODBC_INCLUDE_DIR:-} -L${ODBC_LIB_DIR:-}" \
    -DCMAKE_CXX_STANDARD="${CMAKE_CXX_STANDARD:-20}" \


I am open to suggestions for other locations for -I and -L 🙂

Can we use ARROW_CMAKE_ARGS=-DODBC_ROOT=...?

Hi @kou, is it ok to use ARROW_CMAKE_ARGS+="-I${ODBC_INCLUDE_DIR:-}" in cpp_build.sh? I was looking for other examples inside arrow to pass the -I flag but most examples are inside COMMAND.

Our team has tried passing -DODBC_ROOT and it didn't resolve the header issue.
cc @justing-bq

Could you use it in caller not in cpp_build.sh?

For example:

arrow/.github/workflows/cpp.yml

Lines 331 to 333 in 2009cc9

ARROW_CMAKE_ARGS: >-

-DARROW_PACKAGE_PREFIX=/${{ matrix.msystem_lower}}

-DCMAKE_FIND_PACKAGE_PREFER_CONFIG=ON

Added export CXXFLAGS="$CXXFLAGS -I$ODBC_INCLUDE_DIR" right before calling cpp_build.sh.

alinaliBQ · 2025-12-19T22:50:45Z

cpp/CMakePresets.json

      ],
      "displayName": "Debug build with tests and Flight SQL",
      "cacheVariables": {}
    },


ODBC can be built on Windows and macOS Intel/ARM but it is not available on Linux yet (we will add Linux support later), let me know if this change should be removed until Linux is also supported.

lidavidm · 2025-12-22T08:14:48Z

cpp/src/arrow/flight/sql/odbc/odbc_impl/odbc_handle.h

+    } catch (const arrow::flight::sql::odbc::AuthenticationException& ex) {
+      GetDiagnostics().AddError(arrow::flight::sql::odbc::DriverException(
+          ex.GetMessageText(), ex.GetSqlState(), ex.GetNativeError()));
+    } catch (const arrow::flight::sql::odbc::NullWithoutIndicatorException& ex) {
+      GetDiagnostics().AddError(arrow::flight::sql::odbc::DriverException(
+          ex.GetMessageText(), ex.GetSqlState(), ex.GetNativeError()));
+    }
+    // on mac, DriverException doesn't catch the subclass exceptions hence we added
+    // the following above.
+    // GH-48278 TODO investigate if there is a way to catch all the subclass exceptions
+    // under DriverException
+    catch (const arrow::flight::sql::odbc::DriverException& ex) {


This shouldn't happen...maybe clang is stricter than MSVC?

Yes this is odd, it does seem like undefined behavior. clang being more strict is a possibility.
Without this change, on mac std::exception is caught instead of DriverException, so the exception is still caught but not under DriverException which is preferred

lidavidm · 2025-12-22T08:16:40Z

cpp/src/arrow/flight/sql/odbc/tests/CMakeLists.txt

+if(WIN32)
+  include_directories(${ODBC_INCLUDE_DIRS})
+else()
+  include_directories(${ODBC_INCLUDE_DIR})
+endif()


target_include_directories would be preferable...also why is DIRS/DIR inconsistent between platforms?

Replaced it with target_include_directories. Regarding DIRS/DIR, it has to do with FindODBC.cmake, on Windows, ODBC_INCLUDE_DIRS is set, and on unix systems ODBC_INCLUDE_DIR is set. ODBC_INCLUDE_DIR can be empty on Windows. I added a comment to indicate this.

- Use `target_include_directories`

lidavidm

Seems fine to me, but I'll let people more familiar with the CI setup comment

kou · 2026-01-01T08:35:41Z

ci/scripts/cpp_test.sh

    exclude_tests+=("arrow-s3fs-test")
+    exclude_tests+=("arrow-flight-sql-odbc-test")


Could you keep this list in alphabetical order?

kou · 2026-01-01T08:37:20Z

cpp/src/arrow/flight/sql/odbc/odbc_impl/config/configuration.h

 #include "arrow/flight/sql/odbc/odbc_impl/platform.h"
 #include "arrow/flight/sql/odbc/odbc_impl/spi/connection.h"

+#if defined _WIN32 || defined _WIN64


Do we need to check both of _WIN32 and _WIN64?

_WIN32 is defined for 32 bit and 64 bit Windows:

https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170

_WIN32 Defined as 1 when the compilation target is 32-bit ARM, 64-bit ARM, x86, x64, or ARM64EC. Otherwise, undefined.

Just checking _WIN32 now.

kou · 2026-01-01T08:44:03Z

cpp/src/arrow/flight/sql/odbc/tests/CMakeLists.txt

+# On Windows, cmake uses suffix `DIRS` for ODBC include headers, and
+# on unix, cmake uses suffix `DIR`.
+if(WIN32)
+  target_include_directories(arrow-flight-sql-odbc-test PUBLIC ${ODBC_INCLUDE_DIRS})
+else()
+  target_include_directories(arrow-flight-sql-odbc-test PUBLIC ${ODBC_INCLUDE_DIR})
+endif()


Can we use ODBC::ODBC CMake target instead?

find_package(ODBC REQUIRED) target_link_libraries(arrow-flight-sql-odbc-test PRIVATE ODBC::ODBC)

https://cmake.org/cmake/help/latest/module/FindODBC.html#imported-targets

kou · 2026-01-01T08:47:10Z

.github/workflows/cpp_extra.yml

+          export LIBIODBC_DIR="$(brew --cellar libiodbc)/$(brew list --versions libiodbc | awk '{print $2}')"
+          echo ODBC_INCLUDE_DIR="$LIBIODBC_DIR/include" >> $GITHUB_ENV
+          echo ODBC_LIB_DIR="$LIBIODBC_DIR/lib" >> $GITHUB_ENV


Can we use -DODBC_ROOT instead?

https://cmake.org/cmake/help/latest/module/FindODBC.html#example-finding-a-custom-odbc-installation

I tried it but it didn't work for me.

kou · 2026-01-01T08:47:55Z

ci/scripts/cpp_build.sh

    -DCMAKE_C_FLAGS="${CFLAGS:-}" \
-    -DCMAKE_CXX_FLAGS="${CXXFLAGS:-}" \
+    -DCMAKE_CXX_FLAGS="${CXXFLAGS:-} -I${ODBC_INCLUDE_DIR:-} -L${ODBC_LIB_DIR:-}" \
    -DCMAKE_CXX_STANDARD="${CMAKE_CXX_STANDARD:-20}" \


Can we use ARROW_CMAKE_ARGS=-DODBC_ROOT=...?

alinaliBQ

Thanks for the review Kou. My team is working on the comments locally. cc @justing-bq

alinaliBQ · 2026-01-09T18:29:28Z

ci/scripts/cpp_build.sh

    -DCMAKE_C_FLAGS="${CFLAGS:-}" \
-    -DCMAKE_CXX_FLAGS="${CXXFLAGS:-}" \
+    -DCMAKE_CXX_FLAGS="${CXXFLAGS:-} -I${ODBC_INCLUDE_DIR:-} -L${ODBC_LIB_DIR:-}" \
    -DCMAKE_CXX_STANDARD="${CMAKE_CXX_STANDARD:-20}" \


Hi @kou, is it ok to use ARROW_CMAKE_ARGS+="-I${ODBC_INCLUDE_DIR:-}" in cpp_build.sh? I was looking for other examples inside arrow to pass the -I flag but most examples are inside COMMAND.

Our team has tried passing -DODBC_ROOT and it didn't resolve the header issue.
cc @justing-bq

github-actions bot added Component: C++ Component: FlightRPC awaiting review Awaiting review labels Dec 17, 2025

alinaliBQ mentioned this pull request Dec 17, 2025

GH-48576: [C++][FlightRPC] ODBC: add Mac setup script #48578

Draft

alinaliBQ and others added 4 commits December 18, 2025 12:26

Enable ODBC build in MacOS CI

a7a1be6

Co-Authored-By: justing-bq <[email protected]> Co-Authored-By: Victor Tsang <[email protected]> Co-Authored-By: Alina (Xi) Li <[email protected]>

Enable macOS ODBC CI build

8425399

Co-Authored-By: alinalibq <[email protected]> Co-Authored-By: justing-bq <[email protected]>

Lint fixes

420de63

Enable basic macOS build

581bfcc

added changes to build in MacOS Co-authored-by: vic-tsang <[email protected]>

alinaliBQ force-pushed the gh-48575-macos-odbc-ci branch from f652cbb to 581bfcc Compare December 18, 2025 20:26

alinaliBQ changed the title ~~GH-48575: [C++][FlightRPC] work-in-progress Standalone ODBC macOS CI~~ GH-48575: [C++][FlightRPC] Standalone ODBC macOS CI Dec 19, 2025

alinaliBQ marked this pull request as ready for review December 19, 2025 19:42

alinaliBQ requested review from assignUser, jonkeane, kou, lidavidm and raulcd as code owners December 19, 2025 19:42

alinaliBQ commented Dec 19, 2025

View reviewed changes

github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Dec 19, 2025

lidavidm reviewed Dec 22, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Dec 22, 2025

Work on David's comments

ef3e33b

- Use `target_include_directories`

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 23, 2025

lidavidm reviewed Dec 30, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Dec 30, 2025

kou reviewed Jan 1, 2026

View reviewed changes

alinaliBQ commented Jan 9, 2026

View reviewed changes

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 10, 2026

Address more comments

b67b9cb

	ARROW_CMAKE_ARGS: >-
	-DARROW_PACKAGE_PREFIX=/${{ matrix.msystem_lower}}
	-DCMAKE_FIND_PACKAGE_PREFER_CONFIG=ON

		exclude_tests+=("arrow-s3fs-test")
		exclude_tests+=("arrow-flight-sql-odbc-test")

GH-48575: [C++][FlightRPC] Standalone ODBC macOS CI #48577

Are you sure you want to change the base?

GH-48575: [C++][FlightRPC] Standalone ODBC macOS CI #48577

Uh oh!

Conversation

alinaliBQ commented Dec 17, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alinaliBQ Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lidavidm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alinaliBQ left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alinaliBQ commented Dec 17, 2025 •

edited by github-actions bot

Loading

alinaliBQ Dec 22, 2025 •

edited

Loading