GH-47724: [C++][FlightRPC] ODBC: implement SQLDescribeCol #48052
+969
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alinaliBQ
commented
Nov 4, 2025
github-actions
bot
added
awaiting review
alinaliBQ
force-pushed
the
gh-47724-sql-describe-col
branch
from
3651989 to
cbaabaf
Compare
alinaliBQ
changed the title
Contributor
Author
|
@lidavidm this draft PR is ready for review! Please have a look. Please note: #48052 (comment) |
alinaliBQ
force-pushed
the
gh-47724-sql-describe-col
branch
3 times, most recently
from
b9480f8 to
b6fdfd6
Compare
alinaliBQ
force-pushed
the
gh-47724-sql-describe-col
branch
2 times, most recently
from
e7e471b to
1cf04e2
Compare
alinaliBQ
force-pushed
the
gh-47724-sql-describe-col
branch
from
1cf04e2 to
d6a9d12
Compare
lidavidm
changed the title
lidavidm
reviewed
Jan 5, 2026
Member
There was a problem hiding this comment.
Is there a better way to name these than '2' and '3'?
Contributor
Author
There was a problem hiding this comment.
Yup, I have changed ODBC2 to ODBCVer2 and ODBC3 to ODBCVer3 for better readability
github-actions
bot
added
awaiting changes
This PR depends on SQLColAttribute for descriptor fixes, SQLColumns, SQLTables, and SQLGetTypeInfo for tests Co-Authored-By: rscales <[email protected]>
Work on David's comment.
alinaliBQ
force-pushed
the
gh-47724-sql-describe-col
branch
from
d6a9d12 to
69fa019
Compare
github-actions
bot
added
awaiting change review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Implement SQLDescribeCol which "returns the result descriptor - column name,type, column size, decimal digits, and nullability - for one column in the result set. This information also is available in the fields of the IRD." (Microsoft doc reference)
What changes are included in this PR?
Are these changes tested?
Tested locally on MSVC Windows
Are there any user-facing changes?
n/a