feat(ipc): Remove per-message flush in IPC writer hot path#9763
Open
pchintar wants to merge 1 commit intoapache:mainfrom
Open
feat(ipc): Remove per-message flush in IPC writer hot path#9763pchintar wants to merge 1 commit intoapache:mainfrom
pchintar wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Currently,
flush()is called unconditionally inwrite_body_buffersandwrite_continuation- both executed per batch. This forces per-batch syscalls, breaks write coalescing, and adds unnecessary overhead. These flushes are not required for correctness (IPC boundaries are length-prefixed, no durability guarantees).What changes are included in this PR?
flush()fromwrite_body_buffersandwrite_continuationself.writer.flush()?toStreamWriter::finish()(missing;FileWriter::finish()already has it)Are these changes tested?
Yes the changes were tested successfully by running:
cargo test -p arrow-ipc cargo fmt --all cargo clippy --all-targets --all-features -- -D warningsAre there any user-facing changes?
No, There are no changes made to any Public APIs