Skip to content

refactor(arrow-avro): use Decoder::flush_block in async reader #9726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mzabaluev wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

refactor(arrow-avro): use Decoder::flush_block in async reader #9726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions arrow-avro/src/reader/async_reader/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ impl<R> AsyncAvroFileReader<R> {
/// Drain any remaining buffered records from the decoder.
#[inline]
fn poll_flush(&mut self) -> Poll<Option<Result<RecordBatch, AvroError>>> {
match self.decoder.flush() {
match self.decoder.flush_block() {
Ok(Some(batch)) => {
self.reader_state = ReaderState::Flushing;
Poll::Ready(Some(Ok(batch)))
Expand Down Expand Up @@ -512,7 +512,7 @@ impl<R: AsyncFileReader + Unpin + 'static> AsyncAvroFileReader<R> {
// We have a full batch ready, emit it
// (This is not mutually exclusive with the block being finished, so the state change is valid)
if self.decoder.batch_is_full() {
return match self.decoder.flush() {
return match self.decoder.flush_block() {
Ok(Some(batch)) => Poll::Ready(Some(Ok(batch))),
Ok(None) => self.finish_with_error(AvroError::General(
"Decoder reported a full batch, but flush returned None".into(),
Expand Down
Loading