GH-1039: [Flight] Fix ClassCastException when building FlightClient with domain socket location - #1121
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
ennuite
marked this pull request as ready for review
April 20, 2026 03:00
ennuite
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
April 20, 2026 03:00
Member
|
@ennuite I fixed the CI issue on |
Contributor
Author
Done. I followed the guidelines to rebase using I personally don't like that it pollutes the "Files Change" tab with changes unrelated to the PR. |
Member
|
Is that what you did? That should not produce a PR like this. A rebase should end up with only your commit in the PR. |
Contributor
Author
|
Fixed. Can I get the bug-fix label? |
Member
|
@ennuite please rebase |
lidavidm
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Fix a
ClassCastExceptiononFlightClient.builder().build()when connecting via a Unix domain socket on Linux (epoll) or macOS (kqueue), by casting to the Netty interfaceChannelinstead of the server-specificServerChannel.Also adds netty-transport-native-epoll (Linux) and netty-transport-native-kqueue (macOS) as test-scoped dependencies in flight-core via OS-activated profiles, so the existing
TestServerOptions#domainSockettest actually runs instead of being skipped everywhere.This change was created with AI assistance (Claude Code). All lines were manually reviewed by a human. The output is not copyrightable subject matter.
Closes #1039.