[chart/v1-2x-test] Add terminationGracePeriodSeconds support for PgBouncer in Helm chart (#71237) - #71787
Merged
Conversation
…uncer in Helm chart (#71237) The chart ships a default PgBouncer preStop hook that drains client connections for up to 120 seconds, but the Deployment never sets terminationGracePeriodSeconds, so the Kubernetes default of 30s SIGKILLs the pod mid-drain on a node drain or eviction and cuts in-flight client connections. Every other long-running component in the chart already exposes this value; PgBouncer was the only one missing it, despite being the component that holds the database connections of all the others. The default of 120 matches the drain window of the default preStop hook. PgBouncer exits as soon as the last client connection is released, so the value is an upper bound rather than a fixed wait. (cherry picked from commit 0815a27) Co-authored-by: antruigon <99184149+antruigon@users.noreply.github.com> Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
1 task
Miretpl
marked this pull request as ready for review
August 18, 2026 20:37
Miretpl
requested review from
Miretpl,
bugraoz93,
hussein-awala,
jedcunningham and
jscheffl
as code owners
August 18, 2026 20:37
Miretpl
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart ships a default PgBouncer preStop hook that drains client
connections for up to 120 seconds, but the Deployment never sets
terminationGracePeriodSeconds, so the Kubernetes default of 30s SIGKILLs
the pod mid-drain on a node drain or eviction and cuts in-flight client
connections.
Every other long-running component in the chart already exposes this
value; PgBouncer was the only one missing it, despite being the
component that holds the database connections of all the others.
The default of 120 matches the drain window of the default preStop hook.
PgBouncer exits as soon as the last client connection is released, so
the value is an upper bound rather than a fixed wait.
(cherry picked from commit 0815a27)
Co-authored-by: antruigon 99184149+antruigon@users.noreply.github.com
Co-authored-by: Przemysław Mirowski 17602603+Miretpl@users.noreply.github.com