Fix comma-separated selected_fields in BigQuery to SQL transfers - #71775
Open
FrankYang0529 wants to merge 1 commit into
Open
Fix comma-separated selected_fields in BigQuery to SQL transfers#71775FrankYang0529 wants to merge 1 commit into
FrankYang0529 wants to merge 1 commit into
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
marked this pull request as ready for review
August 19, 2026 07:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The docstring says selected_fields is a "List of fields to return (comma-separated)". The operator passes that value to two places: BigQueryHook.list_rows() splits it on commas, but insert_rows(target_fields=...) does not.
common.sqlbuilds the column list with", ".join(map(escape_word, target_fields)), so a string is iterated character by character. Withselected_fields="emp_name,salary":How
BigQueryToSqlBaseOperator.__init__normalises a comma-separated string intolist[str], soBigQueryToPostgres/BigQueryToMySql/BigQueryToMsSqlall get a real column list on both the BigQuery read and the SQL write side.Verification
uv run --project providers/google pytest providers/google/tests/unit/google/cloud/transfers/test_bigquery_to_postgres.py providers/google/tests/unit/google/cloud/transfers/test_bigquery_to_mysql.py -vWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.