Consolidate AllowlistManager for prek hooks#69327
Draft
jason810496 wants to merge 2 commits into
Draft
Conversation
boring-cyborg
Bot
added
area:dev-tools
backport-to-v3-3-test
jason810496
changed the title
jason810496
changed the title
The allowlist load/save/generate/cleanup logic was duplicated across check_new_airflow_exception_usage.py and check_provide_session_kwargs.py. This consolidates the shared pattern into an abstract AllowListManager in common_prek_utils.py, with subclasses providing only iter_files() and count_occurrences().
The initial extraction left the scan/tighten/report loop duplicated in both hook scripts and exposed `parse` as a staticmethod that silently ignored the instance's `repo_root`. - Convert `parse` from `@staticmethod` to instance method so it always uses `self.repo_root` (fixes the latent footgun where `_parse_tracked_allowlist` called parse unbound). - Hoist the check loop into `AllowlistManager.check()` with `violation_panel_text()` (abstract) and `format_violation_details()` (overridable) hooks — both `_check_*` wrappers are now one-liners. - Fix naming: `AllowListManager` → `AllowlistManager` to match the subclass convention used throughout. - Add test coverage for `check_new_airflow_exception_usage.py`.
jason810496
force-pushed
the
refactor/ci/consolidate-allow-list-manager
branch
from
80d27d2 to
59907b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sessionon@provide_session#67150Why
AllowlistManageris the common pattern now, we should introduce a common interface the common_prek module so that the further use case can reuse them without duplicating the wholeAllowlistManagerone.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5) following the guidelines