Make sure stale file handler doesn't crash the DagFileProcessorManager#69324
Open
dabla wants to merge 3 commits into
Open
Make sure stale file handler doesn't crash the DagFileProcessorManager#69324dabla wants to merge 3 commits into
dabla wants to merge 3 commits into
Conversation
dabla
requested review from
amoghrajesh
and removed request for
ephraimbuddy and
jedcunningham
SameerMesiah97
approved these changes
Jul 3, 2026
SameerMesiah97
left a comment
SameerMesiah97
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Just one nit if you want to address it.
…more DRY approach on how to close the logger file handler and catch OSError if file handler is stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in issue #69321, this PR makes sure a stale file handler doesn't crash the
DagFileProcessorManager. The OSError should be catched and logged as warning instead.Was generative AI tooling used to co-author this PR?
Claude Opus 4.6
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.