Fix asset materialization dropping partition date on partitioned Dag runs#69314
Merged
Merged
Conversation
…runs The materialize_asset route resolved partition_date via validate_context but never passed it to create_dagrun, unlike the sibling trigger route. This left partition_date NULL on materialized runs of partitioned Dags, causing backfill dedup to create duplicate runs and partition-date-window clears to skip them.
Lee-W
changed the title
Lee-W
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
henry3260,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
materialize_assetroute resolvedpartition_dateviavalidate_contextbut never passed it tocreate_dagrun, unlike the sibling/dags/{dag_id}/dagRunstrigger route.partition_dateNULL.What
partition_date=params["partition_date"]intocreate_dagruninmaterialize_asset, matching the trigger route.Was generative AI tooling used to co-author this PR?
Generated-by: [Claude] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.