Skip to content

Improve UpgradeIT - #6603

Merged
DomGarguilo merged 2 commits into
apache:mainfrom
DomGarguilo:improveUpgradeIT
Oct 23, 2026
Merged

DomGarguilo merged 2 commits into
apache:mainfrom
DomGarguilo:improveUpgradeIT

Conversation

@DomGarguilo

@DomGarguilo DomGarguilo commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Added some improvements to UpgradeIT:

b3e2183 Correctness improvement:

  • b3e2183 adds a missing check that no assistant managers are running

84b6998 Other improvements:

  • added a helper method that replaces duplicated code blocks that wait for there to be no servers
  • simplified some assertions (assertTrue -> assertEquals) (use isEmpty() instead of == 0)
  • collapsed the upgrade_ready setup into a single call to drop some variables that are not used elsewhere (also drops two imports)
  • clear ACCUMULO_PROPERTIES_PROPERTY property in a finally block like the other test case does

@DomGarguilo DomGarguilo added this to the 4.0.0 milestone Oct 20, 2026
@DomGarguilo DomGarguilo self-assigned this Oct 20, 2026
@DomGarguilo
DomGarguilo merged commit 62f6532 into apache:main Oct 23, 2026
8 checks passed
@DomGarguilo
DomGarguilo deleted the improveUpgradeIT branch October 23, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants