Repository navigation
Conversation
Amemeda
marked this pull request as ready for review
October 6, 2026 18:04
dlmarion
approved these changes
Oct 6, 2026
DomGarguilo
requested changes
Oct 20, 2026
DomGarguilo
left a comment
Member
There was a problem hiding this comment.
Noticing a few issues here
- The header and body border for the tables are misaligned now. The screenshots you attached to this PR show that.
- scrolling jumps back to the left on every auto-refresh. this makes the new scrolling feature almost unusable. We probably need to save the scroll position before
destroy()and restore it after the DataTable rebuilds. I have not looked into this much so there may be other/better ways to do this too - The reset button tooltip says "Reset column selection and order" which users could get confused with the sort order of the columns. Maybe the tooltip can be more specific and say it resets the "column order"
Amemeda
commented
Oct 22, 2026
| ], | ||
| "columns": getDataTableCols(storageKey) | ||
| }); | ||
| dataTableRef.columns.adjust(); |
Collaborator
Author
There was a problem hiding this comment.
There is a known issue that using the scrollX attribute for horizontal scroll causes the DataTable header and body to become misaligned. This line of code is one of the suggested solutions, and should adjust the sizing of the header and columns after initialization of the DataTable. Also added width 100% to both the table and header, which seems to align every column except for the first two for some reason.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
server_process_common.js:Servers: Compactors
Servers: Managers
Servers: Scan Servers
Servers: Tablet Servers
Activity: Compaction Overview
Display of horizontal scroll and Reset button
Screenshot of Compaction Overview, showing the horizontal scroll bar active on Compaction Coordinator Activity table, and the position of the new reset button:
Reset button includes hover text:
Sample of using Reset button
This pr closes #6546