fix: use PermissionUpdate and PermissionMode types in control protocol#692
Closed
frankgoldfish wants to merge 1 commit intoanthropics:mainfrom
Closed
fix: use PermissionUpdate and PermissionMode types in control protocol#692frankgoldfish wants to merge 1 commit intoanthropics:mainfrom
frankgoldfish wants to merge 1 commit intoanthropics:mainfrom
Conversation
SDKControlPermissionRequest.permission_suggestions was typed as list[Any] and SDKControlSetPermissionModeRequest.mode was typed as str, even though both PermissionUpdate and PermissionMode are already defined in this module. Resolve two TODO comments by using the proper types.
Author
|
Closing this PR — found that PR #624 already addresses this issue. Apologies for the duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves two TODO comments in
src/claude_agent_sdk/types.pyby replacing placeholderAny/strtypes with the proper types that are already defined in the same file.Changes
SDKControlPermissionRequest.permission_suggestionsSDKControlSetPermissionModeRequest.modeWhy
Both
PermissionUpdate(dataclass, lines 72–124) andPermissionMode(Literal type alias, line 18) are already defined intypes.py. Using them here improves type safety and IDE auto-complete for SDK consumers without any runtime behaviour change.Test plan
PermissionUpdateandPermissionModeare imported/defined earlier in the same file — no circular imports🤖 Generated with Claude Code