Fix parallel tool call results lost during session chain reconstruction#675
Open
mtessar wants to merge 1 commit intoanthropics:mainfrom
Open
Fix parallel tool call results lost during session chain reconstruction#675mtessar wants to merge 1 commit intoanthropics:mainfrom
mtessar wants to merge 1 commit intoanthropics:mainfrom
Conversation
When parallel tool calls produce multiple user messages (tool results) sharing the same parentUuid, _build_conversation_chain only followed one linear path from leaf to root, dropping sibling tool results. Add a post-walk pass that finds and inserts missing user-type siblings in file order so all parallel tool results are preserved on session resume. https://claude.ai/code/session_016uRTbX3TazbZbbG1RiDDb8
Author
|
Hi! Happy to make any changes to this if needed. Just let me know. All tests passed so hopefully it's a good fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a bug with serialization of parallel tool calls that shows up when you resume a session from disk. The description below is from Claude Code.
When parallel tool calls produce multiple user messages (tool results) sharing the same parentUuid, _build_conversation_chain only followed one linear path from leaf to root, dropping sibling tool results. Add a post-walk pass that finds and inserts missing user-type siblings in file order so all parallel tool results are preserved on session resume.
https://claude.ai/code/session_016uRTbX3TazbZbbG1RiDDb8