fix: clean up resources in Query.close() to prevent memory leaks#657
Open
MaxwellCalkin wants to merge 1 commit intoanthropics:mainfrom
Open
fix: clean up resources in Query.close() to prevent memory leaks#657MaxwellCalkin wants to merge 1 commit intoanthropics:mainfrom
MaxwellCalkin wants to merge 1 commit intoanthropics:mainfrom
Conversation
The close() method cancels the task group and closes the transport, but does not clear hook_callbacks, pending_control_responses, pending_control_results, or close the memory object streams. In long-running applications or those creating multiple Query instances, these orphaned references prevent garbage collection and cause memory leaks. Add cleanup calls after transport.close() to clear all dictionaries and explicitly close both ends of the anyio memory object stream. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Query.close()cancels the task group and closes the transport, but leaves several resources uncleaned:hook_callbacksdictionary (populated duringinitialize(), never cleared)pending_control_responsesandpending_control_resultsdictionaries_message_sendand_message_receiveanyio memory object streamsQueryinstances, these orphaned references prevent garbage collection and cause memory leaks.suppress(Exception)to handle cases where they may already be closed.Test plan
ruff checkandruff formatpassQueryinstances in a loop, confirm memory usage stays flat🤖 Generated with Claude Code