fix: preserve unrecognized content block types in message parser#651
Open
Bortlesboat wants to merge 1 commit intoanthropics:mainfrom
Open
fix: preserve unrecognized content block types in message parser#651Bortlesboat wants to merge 1 commit intoanthropics:mainfrom
Bortlesboat wants to merge 1 commit intoanthropics:mainfrom
Conversation
The assistant and user message parsers silently dropped content blocks with unrecognized types. Add a RawContentBlock fallback so newer CLI versions don't lose data when the SDK hasn't been updated yet.
Contributor
Author
|
Quick follow-up from my side: I’m treating review-required PRs as top priority this week. If you want any specific changes, rebase, or split, I can turn them around quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typevaluesserver_tool_use,code_execution_result, citations), older SDK versions lose the data entirelyRawContentBlockfallback type andcase _:branches to both parsers so unrecognized blocks are preserved as raw dictsThis follows the same forward-compatibility pattern as #598 (unknown message types) and #574 (unknown MCP content blocks).
Test plan