fix: pass through unrecognized MCP content block types#650
Open
Bortlesboat wants to merge 1 commit intoanthropics:mainfrom
Open
fix: pass through unrecognized MCP content block types#650Bortlesboat wants to merge 1 commit intoanthropics:mainfrom
Bortlesboat wants to merge 1 commit intoanthropics:mainfrom
Conversation
The content conversion loop in _handle_sdk_mcp_request only handled text and image blocks. Other valid MCP content types (EmbeddedResource, ResourceLink, AudioContent, and any future types) were silently dropped. Add an else branch that uses model_dump() for Pydantic objects, passes dicts through directly, and falls back to text coercion for anything else. Fixes anthropics#574
Contributor
Author
|
Quick follow-up from my side: I’m treating review-required PRs as top priority this week. If you want any specific changes, rebase, or split, I can turn them around quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_handle_sdk_mcp_requestmodel_dump(mode="json")instead of discarding themTest plan
EmbeddedResourcecontent block verifying it passes throughFixes #574