fix(app): terminal improvements - focus, rename, error state, CSP #9700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found 2 potentially related PRs that address similar issues:
These appear to be related to the CSP/WASM aspect of your PR. Check if these have already been merged or are still open, as your PR might supersede or complement them. |
Contributor
|
@unitythemaker could you share some gifs/screenshots? |
Contributor
Author
Is this helpful? Edit: I recorded again. |
Contributor
|
@unitythemaker please rebase and resolve conflicts and I'll get this merged! |
Contributor
Author
Sure! |
… state - Close terminal tabs automatically when shell exits - Fix freeze when closing middle tabs - Auto-close terminal panel when last tab is closed - Fix keyboard focus going to terminal instead of chat - Add terminal error state UI showing 'Connection Lost' message - Add terminal rename via double-click or context menu - Add OPENCODE_TERMINAL=1 env var for PTY sessions - Update CSP to allow wasm-unsafe-eval for ghostty terminal
unitythemaker
force-pushed
the
terminal-improvements
branch
from
18f4f8f to
583c259
Compare
Contributor
Author
|
Conflicts resolved! |
sergiu-svinarciuc
pushed a commit
to sergiu-svinarciuc/opencode
that referenced
this pull request
Jan 22, 2026
* dev: (345 commits) fix after merge tweak(session title): change prompt to have the response with user language (anomalyco#9847) fix(app): new workspace button with all languages (anomalyco#9848) chore: generate fix(app): add aria-labels to titlebar and sidebar buttons (anomalyco#9843) test(app): fix e2e wip: black fix: type error fix(app): breaking out of auto-scroll chore: generate feat(app): model tooltip metadata in chooser (per Figma request) (anomalyco#9707) chore: generate fix(app): workspaces padding wonkiness (anomalyco#9772) feat(desktop): properly integrate window controls on windows (anomalyco#9835) test(app): fix e2e fix(app): terminal improvements - focus, rename, error state, CSP (anomalyco#9700) fix(app): japanese language support fix(desktop): add workaround for nushell test(app): fix e2e fix(core): snapshot regression ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
wasm-unsafe-evaltoscript-srcanddata:toconnect-srcfor ghostty WASMnext()andprevious()methods to terminal contextIssues Fixed
exitcommand #6004 - Terminal freezes on shell exit (partially - server-side fix was in fix(app): terminal no longer hangs on exit or ctrl + D and closes the pane #9506)Files Changed
packages/app/src/components/session/session-sortable-terminal-tab.tsx- Rename functionalitypackages/app/src/components/terminal.tsx- Simplified WebSocket close handlingpackages/app/src/context/terminal.tsx- Added error field, improved close() logic, navigationpackages/app/src/pages/session.tsx- Terminal focus effect, error UI, disabled chat autofocuspackages/opencode/src/pty/index.ts- Added OPENCODE_TERMINAL=1 env varpackages/opencode/src/server/server.ts- Updated CSP for WASMTesting
Tested manually with
bun devfor both backend and frontend.