fix(desktop): toggle maximizing window with double click on mac #9168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
Author
|
it seems that @Brendonovich put out a PR for Windows that also fixed it on Mac #9835. closing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9167
Simple change that allows Mac users to double-click to maximize the window by detecting double-clicks in the title bar (and adding
allow-toggle-maximize capabilityto the Tauri capabilities config).This fix only works once the window has actually fully initialized, but this was a pre-existing issue that also prevents the user from re-positioning the window by dragging while the initialization is happening. I think this would also be nice to look at but feels out-of-scope for this quick fix. Also, this change only addresses the issue on Mac.
Before fix:
toggle_maximize_bug.mov
After fix:
toggle_maximize_fix.mov
How did you verify your code works?
Tested the fix locally on my Mac and made sure that lint/typecheck/tests passed